Add Hacker News guidelines button to login screen #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trevor-e
approved these changes
Feb 4, 2025
| @@ -96,6 +110,11 @@ struct LoginScreen: View { | |||
| .padding(32) | |||
| .background(.surface) | |||
| } | |||
|
|
|||
| func openURL(_ urlString: String) { | |||
There was a problem hiding this comment.
think you forgot to use this? same why is above using "https://apple.com"?
| @@ -64,6 +64,20 @@ struct LoginScreen: View { | |||
| .font(.ibmPlexMono(.regular, size: 14)) | |||
| } | |||
|
|
|||
|
|
|||
| HStack(spacing: 0) { | |||
| Text("By signin in, you agree to the ") | |||
📸 Snapshot Test2 modified, 86 unchanged
🛸 Powered by Emerge Tools |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added button to open Hacker New's Guidelines
