DYN-8947 - Add transient state to connectors #16247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8947
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new transient state for connectors to support preview functionality during node auto-complete and clustering operations.
- Updated NodeAutoCompleteBarViewModel to replace "IsConnecting" with the new "IsTransient" state.
- Extended ConnectorViewModel with an IsTransient property and updated the PreviewState logic.
- Added corresponding UI converter properties and updated ConnectorModel to support the transient state.
Reviewed Changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/NodeAutoCompleteViewExtension/ViewModels/NodeAutoCompleteBarViewModel.cs | Replaced connection state logic with transient state handling in node auto-complete and clustering. |
| src/DynamoCoreWpf/ViewModels/Core/ConnectorViewModel.cs | Added IsTransient property and updated PreviewState logic to include a Transient state. |
| src/DynamoCoreWpf/UI/Converters.cs | Introduced TransientBrush and Transient color mappings to support the new state. |
| src/DynamoCore/Graph/Connectors/ConnectorModel.cs | Added IsTransient property with change notification to track the transient state. |
Files not reviewed (2)
- src/DynamoCoreWpf/UI/Themes/Modern/Connectors.xaml: Language not supported
- src/DynamoCoreWpf/UI/Themes/Modern/DynamoConverters.xaml: Language not supported
Comments suppressed due to low confidence (1)
src/DynamoCoreWpf/ViewModels/Core/ConnectorViewModel.cs:533
- [nitpick] Consider adding parentheses to explicitly group the AND condition: if (model.Start.Owner.IsSelected || model.End.Owner.IsSelected || (AnyPinSelected && !IsTransient)). This enhances clarity on how the condition is evaluated.
if (model.Start.Owner.IsSelected || model.End.Owner.IsSelected || AnyPinSelected && !IsTransient)
Co-authored-by: Copilot <[email protected]>
…pierson/Dynamo into dyn8947_transientConnectors
BogdanZavu
reviewed
May 29, 2025
BogdanZavu
reviewed
May 29, 2025
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new transient state to connectors to support preview functionality during node auto-complete and clustering operations. Key changes include:
- Replacing the use of IsConnecting with a new IsTransient state in NodeAutoCompleteBarViewModel.
- Extending ConnectorViewModel and related converters to handle a Transient preview state.
- Updating ConnectorModel and public API documentation to support the transient functionality.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/NodeAutoCompleteViewExtension/ViewModels/NodeAutoCompleteBarViewModel.cs | Updated state logic to use IsTransient and ensure transient connectors are reset appropriately. |
| src/DynamoCoreWpf/ViewModels/Core/ConnectorViewModel.cs | Added new IsTransient property and updated PreviewState enum and getter to include Transient. |
| src/DynamoCoreWpf/UI/Themes/Modern/DynamoConverters.xaml | Added Transient color definitions for the new state. |
| src/DynamoCoreWpf/UI/Converters.cs | Introduced TransientBrush and updated conversion logic to support Transient state. |
| src/DynamoCoreWpf/PublicAPI.Unshipped.txt | Documented the new Transient properties in the public API. |
| src/DynamoCore/Graph/Connectors/ConnectorModel.cs | Added IsTransient property with change notifications. |
| src/DynamoCoreWpf/UI/Themes/Modern/Connectors.xaml | Minor resource dictionary update. |
src/NodeAutoCompleteViewExtension/ViewModels/NodeAutoCompleteBarViewModel.cs
Outdated
Show resolved
Hide resolved
src/NodeAutoCompleteViewExtension/ViewModels/NodeAutoCompleteBarViewModel.cs
Outdated
Show resolved
Hide resolved
src/NodeAutoCompleteViewExtension/ViewModels/NodeAutoCompleteBarViewModel.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <[email protected]>
|
Removed the dashed state from the transient connectors as I don't think it is needed. Purple connectors seem like enough. |
|
Cool! LGTM! |
BogdanZavu
approved these changes
Jun 6, 2025
|
Ran failing test locally and it passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR introduces a new transient state for connectors to support preview functionality during node auto-complete and clustering operations.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Reviewers
@DynamoDS/synapse
FYIs
@Amoursol @achintyabhat