Add ability to detect SPDXIDs by reserved keyname #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matt Rutkowski <[email protected]>
Signed-off-by: Matt Rutkowski <[email protected]>
Signed-off-by: Matt Rutkowski <[email protected]>
Signed-off-by: Matt Rutkowski <[email protected]>
…unctions Signed-off-by: Matt Rutkowski <[email protected]>
Signed-off-by: Matt Rutkowski <[email protected]>
…unctions Signed-off-by: Matt Rutkowski <[email protected]>
…unctions Signed-off-by: Matt Rutkowski <[email protected]>
…unctions Signed-off-by: Matt Rutkowski <[email protected]>
Signed-off-by: Matt Rutkowski <[email protected]>
Signed-off-by: Matt Rutkowski <[email protected]>
Signed-off-by: Matt Rutkowski <[email protected]>
Signed-off-by: Matt Rutkowski <[email protected]>
Signed-off-by: Matt Rutkowski <[email protected]>
Signed-off-by: Matt Rutkowski <[email protected]>
markstur
reviewed
Jun 13, 2024
| if fi.Size() > 1000000 { | ||
| Logger.Errorf("file too large (%v > 1000000)", fi.Size()) // log error, but return nil | ||
| return IdentifierResults{}, nil | ||
| err = Logger.Errorf("file too large (%v > 1000000)", fi.Size()) // log error, but return nil |
There was a problem hiding this comment.
you removed the skipping of large files here
markstur
reviewed
Jun 13, 2024
identifier/identifier.go
Outdated
| NormalizedText: normalizedData.NormalizedText, | ||
| Hash: normalizedData.Hash, | ||
| } | ||
| // ret := IdentifierResults{ |
There was a problem hiding this comment.
don't leave in the commented out code
markstur
reviewed
Jun 13, 2024
Signed-off-by: Matt Rutkowski <[email protected]>
pardon the rename of results to “identifierResults” (uniformly, hopefully) it was necessary for my sanity to assure we only allocated the return struct once and passed it across all pattern matching/find functions and wanted make sure I saw all the places with the type implied by the var name). |
Signed-off-by: Matt Rutkowski <[email protected]>
Signed-off-by: Matt Rutkowski <[email protected]>
Signed-off-by: Matt Rutkowski <[email protected]>
Signed-off-by: Matt Rutkowski <[email protected]>
Signed-off-by: Matt Rutkowski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is a more-and-more popular convention to use the reserved keyname for declaring SPDX license IDs i.e., "SPDX-License-Identifier:" typically placed at the top of source files. The scanner must be able to look for these key-values explicitly (within the first X lines) and use the keyword to distinguish such SPDX IDs like "MIT" from words that contain "mit" in some normalized part of their text.