Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use post type label in meta box settings #4353

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

Soare-Robert-Daniel
Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel commented Jan 9, 2025

Summary

Use the Post Type registered display name as the label instead of using the database slug.

Will affect visual aspect of the product

NO

Screenshots

Normal

Screenshot 2025-01-09 at 17 35 29

BEFORE in Russian

Screenshot 2025-01-09 at 17 44 51

AFTER in Russian

Screenshot 2025-01-09 at 17 47 33

Test instructions

  • Check if the label is displayed correctly.

Check before Pull Request is ready:

Closes https://github.com/Codeinwp/neve-pro-addon/issues/2938

@Soare-Robert-Daniel Soare-Robert-Daniel added the pr-checklist-skip Allow this Pull Request to skip checklist. label Jan 9, 2025
@Soare-Robert-Daniel Soare-Robert-Daniel self-assigned this Jan 9, 2025
@Soare-Robert-Daniel Soare-Robert-Daniel force-pushed the fix/post-type-translation branch from f9ed205 to 0b6a9ff Compare January 9, 2025 15:41
@Soare-Robert-Daniel Soare-Robert-Daniel marked this pull request as ready for review January 9, 2025 15:42
@pirate-bot
Copy link
Collaborator

Plugin build for 0b6a9ff is ready 🛎️!

@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Jan 9, 2025
@Soare-Robert-Daniel Soare-Robert-Daniel merged commit c5692da into development Jan 27, 2025
25 checks passed
@Soare-Robert-Daniel Soare-Robert-Daniel deleted the fix/post-type-translation branch January 27, 2025 13:55
@pirate-bot
Copy link
Collaborator

🎉 This PR is included in version 4.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants