Skip to content

add supporting P3 collisions sub-parameterizations #596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

haakon-e
Copy link
Member

@haakon-e haakon-e commented Jun 21, 2025

This P3 implements:

  • dry freeze rate from Musil (1970) [link]
  • local rime density from Cober and List (1993) [link]

I would find it helpful with a second pair of eyes on the papers to verify my implementation. The docstring and inline comments are quite verbose, so finding your way around the paper is hopefully easy.


  • I have read and checked the items on the review checklist.

@haakon-e
Copy link
Member Author

haakon-e commented Jun 21, 2025

This change is part of the following stack:

Change managed by git-spice.

@haakon-e haakon-e force-pushed the he/rft/wrap-tests-in-testset branch from d054516 to 946768c Compare June 21, 2025 02:22
@haakon-e haakon-e force-pushed the he/feat/p3-collisions-sub-parameterizations branch from 7265c76 to 2ee342c Compare June 21, 2025 02:24
Copy link

codecov bot commented Jun 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.80%. Comparing base (1afcc6b) to head (10438da).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #596      +/-   ##
==========================================
+ Coverage   92.65%   92.80%   +0.14%     
==========================================
  Files          47       47              
  Lines        1756     1792      +36     
==========================================
+ Hits         1627     1663      +36     
  Misses        129      129              
Components Coverage Δ
src 94.10% <100.00%> (+0.12%) ⬆️
ext 69.79% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@haakon-e haakon-e changed the base branch from he/rft/wrap-tests-in-testset to main June 23, 2025 17:12
@haakon-e haakon-e force-pushed the he/feat/p3-collisions-sub-parameterizations branch 2 times, most recently from 76460d6 to 52dac3d Compare June 23, 2025 18:07
* dry freeze rate, from Musil (1970)
* local rime density, from Cober and List (1993)
@haakon-e haakon-e force-pushed the he/feat/p3-collisions-sub-parameterizations branch from 52dac3d to 10438da Compare June 24, 2025 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant