Skip to content

Add triangle inequality limiter option to nonequilibrium parcel example #591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

oalcabes
Copy link
Member

No description provided.

Copy link

codecov bot commented Jun 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.65%. Comparing base (1afcc6b) to head (6d32200).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #591   +/-   ##
=======================================
  Coverage   92.65%   92.65%           
=======================================
  Files          47       47           
  Lines        1756     1756           
=======================================
  Hits         1627     1627           
  Misses        129      129           
Components Coverage Δ
src 93.97% <ø> (ø)
ext 69.79% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@oalcabes oalcabes force-pushed the oa/noneq_parcel_limiter_tests branch from b1c0782 to af79b16 Compare June 16, 2025 23:57
@oalcabes oalcabes marked this pull request as ready for review June 16, 2025 23:57
@oalcabes oalcabes force-pushed the oa/noneq_parcel_limiter_tests branch from 38a2eec to 8fe267c Compare June 17, 2025 00:04
@trontrytel
Copy link
Member

Would it be possible to make all the tendencies in parcel be limited when limiter is set to true? We could use it to test when removing all the q > 0 inside CM.jl?

@oalcabes
Copy link
Member Author

Would it be possible to make all the tendencies in parcel be limited when limiter is set to true? We could use it to test when removing all the q > 0 inside CM.jl?

sure -- in all of the examples as well I guess?

@trontrytel
Copy link
Member

Would it be possible to make all the tendencies in parcel be limited when limiter is set to true? We could use it to test when removing all the q > 0 inside CM.jl?

sure -- in all of the examples as well I guess?

Yes, but I think you would just need to modify the ParcelTendencies file to do it?

@oalcabes oalcabes force-pushed the oa/noneq_parcel_limiter_tests branch from 8fe267c to 937bf60 Compare June 23, 2025 22:04
@oalcabes oalcabes marked this pull request as draft June 24, 2025 00:16
@oalcabes oalcabes force-pushed the oa/noneq_parcel_limiter_tests branch from 609e16f to 937bf60 Compare June 24, 2025 00:56
@oalcabes oalcabes force-pushed the oa/noneq_parcel_limiter_tests branch from 937bf60 to 6d32200 Compare June 24, 2025 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants