Adding new data to AIDA calibrations

[amylu00]

Purpose

• adding TROPIC04 experiment 4, ACI04_22, EXP19, EXP45, and EXP28 to AIDA ice nuc calibrations
• TROPIC04 experiment 4 added to HOM batch

To-do

• in separate PR, overwrite tps to have reference state be more representative of experimental state

Content

---

• I have read and checked the items on the review checklist.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.65%. Comparing base (c04a178) to head (e977f1f).
Report is 3 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #520      +/-   ##
==========================================
+ Coverage   91.53%   92.65%   +1.11%     
==========================================
  Files          45       45              
  Lines        1654     1660       +6     
==========================================
+ Hits         1514     1538      +24     
+ Misses        140      122      -18     

Components	Coverage Δ
src	94.05% <ø> (+1.17%)	⬆️
ext	69.79% <ø> (ø)

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[trontrytel]

Looks like the calibration tests are failing on this PR:

Perfect model calibration on ABDINM: Error During Test at /Users/runner/work/CloudMicrophysics.jl/CloudMicrophysics.jl/test/ice_nucleation_calibration.jl:91
  Got exception outside of a @test
  UndefVarError: `perf_model_params` not defined
  Stacktrace:
    [1] test_J_calibration(FT::Type{Float64}, IN_mode::String)
      @ Main ~/work/CloudMicrophysics.jl/CloudMicrophysics.jl/test/ice_nucleation_calibration.jl:9
    [2] macro expansion
      @ ~/work/CloudMicrophysics.jl/CloudMicrophysics.jl/test/ice_nucleation_calibration.jl:92 [inlined]
    [3] macro expansion
      @ ~/hostedtoolcache/julia/1.10.9/aarch64/share/julia/stdlib/v1.10/Test/src/Test.jl:1577 [inlined]
    [4] top-level scope
      @ ~/work/CloudMicrophysics.jl/CloudMicrophysics.jl/test/ice_nucleation_calibration.jl:92
    [5] include(fname::String)
      @ Base.MainInclude ./client.jl:494
    [6] top-level scope
      @ ~/work/CloudMicrophysics.jl/CloudMicrophysics.jl/test/runtests.jl:19
    [7] include(fname::String)
      @ Base.MainInclude ./client.jl:494
    [8] top-level scope
      @ none:6
    [9] eval
      @ ./boot.jl:385 [inlined]
   [10] exec_options(opts::Base.JLOptions)
      @ Base ./client.jl:296
   [11] _start()
      @ Base ./client.jl:557
Test Summary:                       | Error  Total  Time
Perfect model calibration on ABDINM |     1      1  1.2s

[trontrytel]

Why can J become negative?

[amylu00]

I was keeping it consistent with the ABDINM, I can change it back. I think I implemented it before because the parcel was giving negative radii and N_l values because there wasn't a limit on the condensation/depositional growth tendencies

[trontrytel]

Could you try limiting the tendency in a similar way as we do in other places? For example this is what we have in immersion freezing

  return ifelse(
       cond_rate > FT(0),
       min(cond_rate, limit(qᵥ, dt, 1)),
       -min(abs(cond_rate), limit(qₗ, dt, 1)),
   )

[amylu00]

Yes, I'll update the limiting in condensational growth the same way too

[trontrytel]

So much dust!

[amylu00]

🧹💨

[trontrytel]

Thank you!