Skip to content

Fix/mobile settings panel #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

onyedikachi-david
Copy link
Contributor

/claim #121
Fixes: #121

Added support for both mobile and tablet views

Screen.Recording.2025-03-08.at.12.15.57.mov

Verified

This commit was signed with the committer’s verified signature.
onyedikachi-david David Anyatonwu

Verified

This commit was signed with the committer’s verified signature.
onyedikachi-david David Anyatonwu
@alxlion
Copy link
Contributor

alxlion commented Mar 13, 2025

You forgot to execute mix format before committing to format your code 😉

@onyedikachi-david
Copy link
Contributor Author

Apologies. Will do that and push

mix fmt

Verified

This commit was signed with the committer’s verified signature.
onyedikachi-david David Anyatonwu
Signed-off-by: David Anyatonwu <[email protected]>
@onyedikachi-david
Copy link
Contributor Author

@alxlion done

@alxlion
Copy link
Contributor

alxlion commented Mar 23, 2025

Sorry, this does not work properly. The settings panel is always hidden and it doesn't use the original popup like the screenshot.

This has been fixed in 8e64845

CleanShot 2025-03-23 at 13 52 28
CleanShot 2025-03-23 at 13 51 39

@alxlion alxlion closed this Mar 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants