chore: upgrade biomejs to 1.9.4 #7533
Open
+232
−243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Major change in this PR is rule nursery/useAtIndex. But the change is very important as it improves the type safety. const myArray: number[] = []
// Resolved to type `number`
const lastElement1 = myArray[myArray.length - 1];
// Resolved to type `number | undefined`
const lastElement2 = myArray.at(-1); As you notice in the first case, if the array is empty the type for |
Performance Report✔️ no performance regression detected Full benchmark results
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #7533 +/- ##
=========================================
Coverage 50.14% 50.15%
=========================================
Files 603 603
Lines 40454 40442 -12
Branches 2226 2227 +1
=========================================
- Hits 20285 20282 -3
+ Misses 20129 20118 -11
- Partials 40 42 +2 🚀 New features to boost your workflow:
|
nflaig
reviewed
Mar 7, 2025
| @@ -272,7 +272,7 @@ export function getBeaconPoolApi({ | |||
| chain.syncCommitteeMessagePool.add(subnet, signature, indexInSubcommittee); | |||
|
|
|||
| // Cheap de-duplication code to avoid using a Set. indexesInCommittee is always sorted | |||
| if (subnets.length === 0 || subnets[subnets.length - 1] !== subnet) { | |||
| if (subnets.length === 0 || subnets.at(-1) !== subnet) { | |||
There was a problem hiding this comment.
so -1 seems to be last item in the array, this is very confusing syntax
There was a problem hiding this comment.
Yes negative indexes are treated backwards. Which is also consistently used in other JS functions. e.g. arr.slice(-2); returns last two items.
There was a problem hiding this comment.
arr.slice(-2); returns last two items.
yeah I know, somehow it makes more sense to me there, it's probably just a matter of getting used to it, if that's what needed to make array access more type safe I am all for it
There was a problem hiding this comment.
Yes .at give type-safety compared to index access of the array. In case of under index or over index access the array returns undefined but the type for index access is always without undefined. Which is resolved with .at, so you must check if what you accessed is available or not.
There was a problem hiding this comment.
But that also need a careful review because if(!arr.at(-1)) such usages may fail if last value exists but is some falsy.
nflaig
reviewed
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Keep the tooling updated.
Description
Steps to test or reproduce
Run all tests.
Please review commit by commit
For reviewers please review commit by commit.