US990352: Correlate specific documents with audit events #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6fc942d.
|
StreamingWorkerWrapper::run() actually already adds the correlation-id to MDC in workers: |
Description of ChangesPre-existing correlation ID logicAs the comment above shows, worker-framework already has logic that takes correlation id from the incoming worker task and sets it in the MDC context. Changes in this MRThere was also logic present in workflow-worker that checked the custom data for a correlation id. The MDC context would then be overwritten with the correlation id in custom data or else one was generated - this was overwriting the existing worker-framework code mentioned above. The changes in this MR fix this so that if a correlation ID has been set in the MDC context, this is set in the custom data of the outgoing message (otherwise one is generated and set). |
dermot-hardy
requested changes
Feb 17, 2025
worker-workflow/src/main/java/com/github/cafdataprocessing/workers/workflow/WorkflowWorker.java
Outdated
Show resolved
Hide resolved
dermot-hardy
requested changes
Feb 19, 2025
dermot-hardy
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://internal.almoctane.com/ui/entity-navigation?p=131002/6001&entityType=work_item&id=990352