docs: fix nixpkgs link #3053
Open
docs: fix nixpkgs link #3053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At least I hope this is the right one
RossSmyth
reviewed
Jun 9, 2025
There was a problem hiding this comment.
Linking to the source file is sort of meaningless. It would be best to link to something like
https://search.nixos.org/packages?channel=unstable&show=ripgrep&from=0&size=50&sort=relevance&type=packages&query=ripgrep
Comment on lines
317
to
318
| ``` | ||
| $ nix-env --install ripgrep |
There was a problem hiding this comment.
nix-env is not really recommended these days because it modifies global state. Either:
Suggested change
| ``` | |
| $ nix-env --install ripgrep | |
| Add this to your NixOS or Home-Manager config. | |
| ```nix | |
| environment.systemPackages = [ | |
| pkgs.ripgrep | |
| ]; |
or
Suggested change
| ``` | |
| $ nix-env --install ripgrep | |
| To temporarily add it to your `$PATH` | |
| ```bash | |
| $ nix-shell -p ripgrep |
There was a problem hiding this comment.
Just commenting to support that this recommendation is more modern and agreed upon than nix-env. I would prefer to see these suggestions go in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least I hope this is the right one