Refactor api #2
Open
Refactor api #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PunitGr
requested changes
Jun 16, 2025
PunitGr
reviewed
Jun 19, 2025
| app/.idea | ||
| app/.venv | ||
| app/orm-user.db | ||
| app/app/__pycache__ |
There was a problem hiding this comment.
You can do **/__pycache__/ instead.
| app/app/auth/__pycache__ | ||
| app/app/core/__pycache__ | ||
| app/app/db/__pycache__ | ||
| app/app/models/__pycache__ |
There was a problem hiding this comment.
Lets add linting to the project, have a look at: https://github.com/astral-sh/ruff
| raise HTTPException(status_code=400, detail="Email already exists") | ||
|
|
||
| while True: | ||
| username = name + str(random.randint(1, 100)) |
There was a problem hiding this comment.
You can use slugify instead.
| router = APIRouter() | ||
|
|
||
| @router.post("/signup") | ||
| async def add_user(session: Session = Depends(get_session), name: str = "", password: str = "", email: str = ""): |
There was a problem hiding this comment.
I recommend using Pydantic models (e.g., BaseModel classes) for the request body instead of passing parameters like name, email, and password directly in the function signature.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.