feat: txe native world state #11226
Open
feat: txe native world state #11226
+250
−175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sklppy88
force-pushed
the
ek/feat/txe-native-world-state-3
branch
2 times, most recently
from
22175df to
60872a1
Compare
sklppy88
force-pushed
the
ek/feat/txe-native-world-state-3
branch
from
60872a1 to
ca367f4
Compare
Thunkar
reviewed
Jan 23, 2025
| await (this.typedOracle as TXE).addNullifiers(addressFromSingle(contractAddress), fromArray(nullifiers)); | ||
| return toForeignCallResult([]); | ||
| } | ||
| // async addNullifiers(contractAddress: ForeignCallSingle, _length: ForeignCallSingle, nullifiers: ForeignCallArray) { |
Thunkar
reviewed
Jan 23, 2025
| ); | ||
| await this.txe.addPublicDataWrites([new PublicDataWrite(computePublicDataTreeLeafSlot(contract, slot), newValue)]); | ||
|
|
||
| // await this.merkleDb.batchInsert( |
sklppy88
force-pushed
the
ek/feat/txe-native-world-state-3
branch
4 times, most recently
from
73bebfa to
e91fd71
Compare
sklppy88
force-pushed
the
ek/feat/txe-native-world-state-3
branch
2 times, most recently
from
53eafb8 to
cd760ae
Compare
Thunkar
reviewed
Jan 24, 2025
| @@ -239,10 +261,14 @@ export class TXE implements TypedOracle { | |||
| sideEffectsCounter = this.sideEffectCounter, | |||
| isStaticCall = false, | |||
| ) { | |||
| const db = await this.#getTreesAt(blockNumber); | |||
| const previousBlockState = await this.#getTreesAt(blockNumber - 1); | |||
| if (blockNumber >= this.blockNumber) { | |||
There was a problem hiding this comment.
Mmm, this is weird. Shouldn't we issue an error or something if someone tries to ask for stuff in the future?
Thunkar
reviewed
Jan 24, 2025
| header.state = await db.getStateReference(); | ||
| header.globalVariables.blockNumber = new Fr(blockNumber); | ||
| if (blockNumber === 1) { | ||
| throw new Error('This is dickered'); |
sklppy88
force-pushed
the
ek/feat/txe-native-world-state-3
branch
from
cd760ae to
57e5cf4
Compare
sklppy88
force-pushed
the
ek/feat/txe-native-world-state-3
branch
from
57e5cf4 to
d05b12d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see this PR. Decided to start fresh as there was a bunch of conflicts after coming back from hols.