Add -server launcher argument #10914
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds -server argument for auto connecting to server on startup Example usage: java -jar desktop.jar -server localhost This can be useful in game launchers
1ue999
suggested changes
Jun 10, 2025
| @@ -44,7 +45,7 @@ public static void main(String[] arg){ | |||
| width = 900; | |||
| height = 700; | |||
| gl30Minor = 2; | |||
| gl30 = true; | |||
| gl30 = true; | |||
There was a problem hiding this comment.
Why put a trailing whitespace there?
| @@ -72,14 +73,24 @@ public static void main(String[] arg){ | |||
| handleCrash(e); | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
No point in removing that whitespace...?
|
|
||
| Events.on(ClientLoadEvent.class, event -> { | ||
| // Now (if -server option is present) we inject server to serverlist and automaticly connect to it. | ||
| if (Seq.with(args).contains("-server")) { |
There was a problem hiding this comment.
why not use serverAddr (init it to null) instead of that?
| Log.info("Autoconnecting to server " + serverAddr); | ||
| int port = Vars.port; // TODO: Use port specified in Vars. | ||
| if (serverAddr.contains(":")) { | ||
| port = Strings.parseInt(serverAddr.substring(serverAddr.indexOf(":")+1)); |
There was a problem hiding this comment.
this WILL break with ipv6 addresses.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds -server argument for auto connecting to server on startup
Example usage: java -jar desktop.jar -server localhost
This can be useful in game launchers(example: some server with mods that has launcher to automatically downloads new version of mindustry(if avaible) and mods, and starts desktop.jar with -server arg).
(i used vscodium btw)
If your pull request is not translation or serverlist-related, read the list of requirements below and check each box: