Fixed calculation problems when deconstruct #10897
Conversation
|
@Anuken The original remaining is not accurate. You should use "the total materials that should be given to you" - "the materials currently given to you" instead of "total cost x refund multiplier" - "total cost - construction cost + materials currently given to you". |
| @@ -171,6 +172,7 @@ public class ConstructBuild extends Building{ | |||
| private @Nullable float[] accumulator; | |||
| private @Nullable float[] totalAccumulator; | |||
| private @Nullable int[] itemsLeft; | |||
| private @Nullable int[] refundedItems; | |||
There was a problem hiding this comment.
Why add a new array? As far as I can tell, you're always incrementing refundedItems and itemsLeft by the same amount, so their values should be identical at the end.
There was a problem hiding this comment.
Why add a new array? As far as I can tell, you're always incrementing refundedItems and itemsLeft by the same amount, so their values should be identical at the end.
Besides this, itemsLeft has an initial value, so it is not equal to the amount of materials given to you during the process. It is also not equal to refundItems
There was a problem hiding this comment.
@Anuken
I found that the initial value of itemsLeft[i] is equal to total construction cost - construction cost, meaning it is 0 when you have fully built it, but not otherwise.
I get the amount obtained in the process through
Because itemsLeft[i] = totalCost[i] - usedItems[i] + refundedItems[i]
So I get usedItems[i], and then I get the total amount that should be given to you, that is, totalRefundItems[i] = usedItems[i] * deconstructMultiplier, and then I use totalRefundItems[i - refundedItems[i] to get the most accurate amount of compensation.
But even so, I found other problems. For example, if deconstructMultiplier = 2, I spent 7 coppers to build it, and refundedItems[i] = 15, it gave me one more, which means that I can't give it, but I have to reduce it by one.