Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add nullable return types to API mustache templates #748

Merged
merged 7 commits into from
Mar 13, 2025
Merged

Add nullable return types to API mustache templates #748

merged 7 commits into from
Mar 13, 2025

Conversation

ayodejidev
Copy link
Contributor

Description

Updated API mustache tempates to include nullable return types to better reflect their behavior, improve type safety and support php v8+.

@ayodejidev ayodejidev requested a review from a team as a code owner March 10, 2025 09:01
gcatanese
gcatanese requested changes Mar 10, 2025
View reviewed changes
Copy link

@gcatanese gcatanese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I suggest to remove NullableTypeDeclarationTest and instead consider adding a unit test in the SDK Automation generation to verify the signature of the generated methods.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@ayodejidev ayodejidev merged commit 34ccb68 into main Mar 13, 2025
4 checks passed
@ayodejidev ayodejidev deleted the support-explicit-nullable branch March 13, 2025 12:57
@AdyenAutomationBot AdyenAutomationBot mentioned this pull request Mar 13, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gcatanese gcatanese gcatanese approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ayodejidev @gcatanese