This repository has been archived by the owner on Jan 6, 2022. It is now read-only.
generated from TryGhost/Starter
-
Notifications
You must be signed in to change notification settings - Fork 12
gulpfile: Refine build pipeline #277
Draft
wei2912
wants to merge
13
commits into
master
Choose a base branch
from
gulp-refine
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quite strangely, the source map for |
Ideally this should be worked on after #288 is settled. |
wei2912
force-pushed
the
gulp-refine
branch
from
September 11, 2021 14:02
1c8e065
to
d5e5357
Compare
Rebased onto ec37f62. |
From this commit, it appears that JS and CSS compression work fine and the source maps are generated. However, my browser claims that these source maps link to nowhere, so I'm not sure how to proceed... passing this on to @bnjmnt4n for review. |
After investigating further, it seems like
I have no idea where the |
Sorry but I'm not quite sure what needs to be done here |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
bug
Something isn't working
enhancement
New feature or request
help wanted
Extra attention is needed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a couple of refinements to
gulpfile.js
and related build pipelines, such asautoprefixer
, CSS compression, proper source maps, production zipping and reloading based on changes to config files.