Skip to content

moved find_clips function to superclass and added test case #1902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 20, 2025

Conversation

cato-o
Copy link
Contributor

@cato-o cato-o commented Jun 14, 2025

Summarize your change:
Moving find_clips to the Composition superclass so it only needs to be defined once. It was previously defined in both Track and Stack subclasses.

Reference associated tests:
Added a new test called "test_find_clips" to both test_stack_algo.cpp and test_track.cpp.

@codecov-commenter
Copy link

codecov-commenter commented Jun 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.79%. Comparing base (c0e97b0) to head (11ccc95).
Report is 58 commits behind head on main.

❌ Your changes status has failed because you have indirect coverage changes. Learn more about Unexpected Coverage Changes and reasons for indirect coverage changes.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1902      +/-   ##
==========================================
+ Coverage   84.11%   84.79%   +0.67%     
==========================================
  Files         198      177      -21     
  Lines       22241    12786    -9455     
  Branches     4687     1193    -3494     
==========================================
- Hits        18709    10842    -7867     
+ Misses       2610     1761     -849     
+ Partials      922      183     -739     
Flag Coverage Δ
py-unittests 84.79% <100.00%> (+0.67%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/opentimelineio/composition.cpp 79.36% <100.00%> (+12.80%) ⬆️
src/opentimelineio/composition.h 83.87% <ø> (+18.35%) ⬆️
src/opentimelineio/stack.cpp 75.67% <ø> (+5.83%) ⬆️
src/opentimelineio/track.cpp 91.11% <ø> (+17.30%) ⬆️
src/opentimelineio/track.h 100.00% <ø> (ø)
...entimelineio-bindings/otio_serializableObjects.cpp 94.58% <100.00%> (+0.73%) ⬆️

... and 130 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bacf095...11ccc95. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@darbyjohnston
Copy link
Contributor

The changes look good, if you can rebase/merge your branch with the latest then I think this PR is ready. Thanks!

@darbyjohnston darbyjohnston added the maintenance General cleanup and good code hygiene label Jun 19, 2025
@darbyjohnston darbyjohnston added this to the Public Beta 18 milestone Jun 19, 2025
cato-o added 5 commits June 20, 2025 09:51
Signed-off-by: Yingjie Wang <[email protected]>
Signed-off-by: Yingjie Wang <[email protected]>
Signed-off-by: Yingjie Wang <[email protected]>
@cato-o
Copy link
Contributor Author

cato-o commented Jun 20, 2025

Rebased and ready I think! Thank you :)

@darbyjohnston darbyjohnston merged commit 7c58de1 into AcademySoftwareFoundation:main Jun 20, 2025
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance General cleanup and good code hygiene python-bindings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants