-
Notifications
You must be signed in to change notification settings - Fork 304
moved find_clips function to superclass and added test case #1902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
moved find_clips function to superclass and added test case #1902
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❌ Your changes status has failed because you have indirect coverage changes. Learn more about Unexpected Coverage Changes and reasons for indirect coverage changes. Additional details and impacted files@@ Coverage Diff @@
## main #1902 +/- ##
==========================================
+ Coverage 84.11% 84.79% +0.67%
==========================================
Files 198 177 -21
Lines 22241 12786 -9455
Branches 4687 1193 -3494
==========================================
- Hits 18709 10842 -7867
+ Misses 2610 1761 -849
+ Partials 922 183 -739
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 130 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
The changes look good, if you can rebase/merge your branch with the latest then I think this PR is ready. Thanks! |
Signed-off-by: Yingjie Wang <[email protected]>
…parent class test script Signed-off-by: Yingjie Wang <[email protected]>
Signed-off-by: Yingjie Wang <[email protected]>
Signed-off-by: Yingjie Wang <[email protected]>
Signed-off-by: Yingjie Wang <[email protected]>
Rebased and ready I think! Thank you :) |
7c58de1
into
AcademySoftwareFoundation:main
Summarize your change:
Moving
find_clips
to the Composition superclass so it only needs to be defined once. It was previously defined in both Track and Stack subclasses.Reference associated tests:
Added a new test called "test_find_clips" to both
test_stack_algo.cpp
andtest_track.cpp
.