Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENG-5733 feat(launchpad): rewards page v0 scaffolding #1098

Merged

Conversation

Vitalsine85
Copy link
Member

Affected Packages

Apps

  • data populator
  • portal
  • template
  • launchpad

Packages

  • 1ui
  • api
  • graphql
  • protocol
  • sdk

Tools

  • tools

Overview

Overview of the changes in the PR.

Screen Captures

If applicable, add screenshots or screen captures of your changes.

Declaration

  • I hereby declare that I have abided by the rules and regulations as outlined in the CONTRIBUTING.md

Copy link

linear bot commented Feb 8, 2025

@github-actions github-actions bot added the feat Feature label Feb 8, 2025
Copy link
Member

@jonathanprozzi jonathanprozzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

Hopefully some of the previous components I had from the other branch were helpful

}) => {
return (
<div className="flex flex-col theme-border rounded-lg p-6 gap-4 bg-black">
{/* <div className="flex flex-col gap-1">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we don't need we can remove this commented code

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I don't think we will since the total points is listed in the component above it. We can add it back in later if needed.

@@ -93,3 +93,26 @@ export function truncateString(str: string, maxLength: number): string {
}
return `${str.slice(0, maxLength)}...`
}

export const truncateNumber = (balance: string | number): string => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More and more we have reason to create a shared utils package at this point, especially if we're moving toward having smart components in 1ui

@auroter @orbro vis

@Vitalsine85 Vitalsine85 force-pushed the vital/eng-5733-rewards-page-v0-scaffolding branch from f2f314a to 99fe09d Compare February 11, 2025 16:19
@Vitalsine85 Vitalsine85 merged commit 891d4ff into feature/launchpad-dev Feb 11, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants