ENG-5683 feat(launchpad,1ui,graphql): update network page based on new designs #1094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanprozzi
approved these changes
Feb 6, 2025
Vitalsine85
force-pushed
the
vital/eng-5683-bring-back-the-network-page-when-things-are-resolved
branch
from
1364c12 to
713a164
Compare
Vitalsine85
deleted the
vital/eng-5683-bring-back-the-network-page-when-things-are-resolved
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Affected Packages
Apps
Packages
Tools
Overview
Note: This PR is based off of #1093, do not merge this in until that is merged in and this branch is rebased.
Reintroduces the Network route with updated aggregated metrics and activity feed. Ported the activity feed from Portal into Launchpad. Doesn't match the Koncepted designs exactly, but I don't think we need to rebuild an entirely new feed, we just have to make a few more tweaks.
I am wondering if we want to modify the feed even further inside of Launchpad to reflect upvotes, since we are using that terminology and flow in the questions? This is a question for the larger group that I will raise.
Screen Captures
Declaration