Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENG-5747 feat(launchpad,graphql): get relic/protocol points on launchpad rewards page #1092

Conversation

Vitalsine85
Copy link
Member

Affected Packages

Apps

  • data populator
  • portal
  • template
  • launchpad

Packages

  • 1ui
  • api
  • graphql
  • protocol
  • sdk

Tools

  • tools

Overview

NOTE: Do not merge this in before the temporary activity fix, this is based on that branch, sorry.

Pulls in relic points and protocol fees for protocol points on the rewards page, in addition to general point aggregates. Eventually we will use the points events table, but in the meantime we need a temporary solution, and while this is fragmented it works. We just can't get a leaderboard at the moment.

Screen Captures

If applicable, add screenshots or screen captures of your changes.

Declaration

  • I hereby declare that I have abided by the rules and regulations as outlined in the CONTRIBUTING.md

Copy link

linear bot commented Feb 3, 2025

@github-actions github-actions bot added the feat Feature label Feb 3, 2025
Copy link
Member

@jonathanprozzi jonathanprozzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few questions and some consoles to remove. Nice job! Glad you could use some from the other branch.

@@ -67,6 +68,7 @@ export function getEnv() {
process.env.MULTIVAULT_ADDRESS_BASE_MAINNET,
ORIGIN_URL: process.env.ORIGIN_URL,
PRIVY_APP_ID: process.env.PRIVY_APP_ID,
HASURA_POINTS_ENDPOINT: process.env.HASURA_POINTS_ENDPOINT,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also need this on the client?

apps/launchpad/app/lib/graphql/client.ts Outdated Show resolved Hide resolved
return useQuery({
queryKey: ['get-relic-points', { address }],
queryFn: () => {
console.log('Query function executing with address:', address)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logger instead or we can prob remove

return {
address,
dehydratedState: dehydrate(queryClient),
initialParams: {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you have any trouble from omitting address from the initialParams? I know we have anyway from the loader but did this cause cache issues with the key?

@Vitalsine85 Vitalsine85 changed the title ENG-5747 feat(launchpad): get relic/protocol points on launchpad rewards page ENG-5747 feat(launchpad,graphql): get relic/protocol points on launchpad rewards page Feb 4, 2025
@Vitalsine85 Vitalsine85 force-pushed the vital/eng-5698-update-relic-points-on-portal branch from 0eb46ac to de82b4f Compare February 4, 2025 20:36
@Vitalsine85 Vitalsine85 merged commit 2c618b3 into feature/launchpad-dev Feb 6, 2025
2 checks passed
Vitalsine85 added a commit that referenced this pull request Feb 6, 2025
## Affected Packages

Apps

- [ ] data populator
- [ ] portal
- [ ] template
- [x] launchpad

Packages

- [ ] 1ui
- [ ] api
- [x] graphql
- [ ] protocol
- [ ] sdk

Tools

- [ ] tools

## Overview

Note: This is based off of
#1092 so do not merge
until that is in and this branch is rebased.

Scaffolds Home/Dashboard with updated design based on Koncepted handoff.
Made some general changes to the overall layout based on their designs
as well, namely in the sidebar.

This uses real data for the aggregated points value, but we still don't
have timeseries data to be able to update the values in the cards below
the aggregated IQ. That will get done in another pass when that data is
ready and we are polishing.

## Screen Captures


![image](https://github.com/user-attachments/assets/4402941d-d4dd-4972-93ee-456959534634)

## Declaration

- [x] I hereby declare that I have abided by the rules and regulations
as outlined in the
[CONTRIBUTING.md](https://github.com/0xIntuition/intuition-ts/blob/main/CONTRIBUTING.md)
@Vitalsine85 Vitalsine85 deleted the vital/eng-5698-update-relic-points-on-portal branch February 7, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants