ENG-5665 feat(launchpad,1ui): implement downvoting #1085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vitalsine85
force-pushed
the
vital/eng-5665-implement-redeemingdown-voting
branch
from
46f9cc1 to
c97a376
Compare
Vitalsine85
changed the title
jonathanprozzi
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Affected Packages
Apps
Packages
Tools
Overview
Introduces downvoting and further improves the signal/voting UX. Added gradients to table and updated modal bg and border. Improved vault details fetching. Removed unused components related to survey/staking/signaling. Updated signal step in survey flow.
Note: still working through the vote math... 1 vote = minDeposit, but we have to account for the fees when calculating it on the frontend. In the case of transactions, 1 tick always = minDeposit, or if you're redeeming, it will redeem all if parsedTick +1 > your shares. In the case of showing someone their ticks post transaction and fees, we have to do 0.94 * minDeposit to account for the 5% entry and 1% protocol fees. Still seems to be some rounding issues though. Continuing to work through that but we can test this now.
Screen Captures
https://www.loom.com/share/655f4ec38b1a40baa0b56f3120c32188?sid=cfc75cc0-b176-4446-a321-02923a2bdadc
Declaration