Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENG-5607 feat(launchpad): reintroduce privy clientid to launchpad #1067

Open
wants to merge 1 commit into
base: feature/launchpad
Choose a base branch
from

Conversation

Vitalsine85
Copy link
Member

@Vitalsine85 Vitalsine85 commented Jan 24, 2025

Affected Packages

Apps

  • data populator
  • portal
  • template
  • launchpad

Packages

  • 1ui
  • api
  • graphql
  • protocol
  • sdk

Tools

  • tools

Overview

Reintroduces the Privy ClientID to Launchpad, which allows us to use the same appId, but gives us more granular control over any other apps built on top/alongside it, so that we can share the user base.

Also moved some mock data files into the shared data folder in lib.

Screen Captures

If applicable, add screenshots or screen captures of your changes.

Declaration

  • I hereby declare that I have abided by the rules and regulations as outlined in the CONTRIBUTING.md

Copy link

linear bot commented Jan 24, 2025

@Vitalsine85 Vitalsine85 changed the base branch from main to feature/launchpad January 24, 2025 17:38
Copy link
Member

@jonathanprozzi jonathanprozzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reintroducing -- this should be fine but let's test again after the other Privy PR is tested so we can make sure we don't introduce too many variables!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants