Skip to content

Avoid sending no-op message edits to server #1014

Open
@neiljp

Description

@neiljp
Collaborator

Currently there are cases when editing a message, where we send details to the server of a message edit, even if the topic or content have not changed. These 'no op' edits are not currently identified by the server and can lead to unexpected no-change entries in message history.

After zulip/zulip#16317 and zulip/zulip#17193 these should not be a problem and filtered from the server side, but this will remain an issue for running against older servers until the release with these PRs is our minimum supported version.

Even when those server fixes are in place, the checks added as part of resolving this issue will contribute to allowing

  • minor network optimizations
  • potentially hooking UI alerts regarding trying to send an edit with no changes

Activity

added this to the Next Release milestone on Apr 28, 2021
changed the title [-]Minimize sending no-op message edits to server[/-] [+]Avoid sending no-op message edits to server[/+] on Apr 28, 2021
self-assigned this
on Jun 24, 2021
zulipbot

zulipbot commented on Jul 16, 2021

@zulipbot
Member

Hello @neiljp, you claimed this issue to work on it, but this issue and any referenced pull requests haven't been updated for 10 days. Are you still working on this issue?

If so, please update this issue by leaving a comment on this issue to let me know that you're still working on it. Otherwise, I'll automatically remove you from this issue in 4 days.

If you've decided to work on something else, simply comment @zulipbot abandon so that someone else can claim it and continue from where you left off.

Thank you for your valuable contributions to Zulip!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @neiljp@zulipbot

        Issue actions

          Avoid sending no-op message edits to server · Issue #1014 · zulip/zulip-terminal