SOCKET no longer defined since winsock2.h removed from zmq.h

[Dysl3xik]

If you try to build this library with a newer release of ZeroMQ, on a windows box, you get errors because SOCKET can't be resolved in compatability.h.

This was introduced in this merge I believe: zeromq/libzmq#3681

I will submit a PR that introduces the same fix into this code base as was proposed in that one.

[sigiesec]

Sounds good, thank you!

[Dysl3xik]

Oops deeply sorry, I meant to post this to https://github.com/zeromq/zmqpp !

[daravi]

Hi. I also see this issue (at least with Visual Studio 17). I have to add winsock2.h include to zmq.hpp before I could compile my consuming project. I am confused why this issue was closed. Is a PR welcomed or is there a more preferable solution?

#ifdef _WIN32
#include <winsock2.h>
#endif

[jaewooklee93]

I've encountered same error

@daravi 's solution nicely works.

Also, I'd like to point out #include statements should be below #define NOMINMAX

#ifdef _WIN32
#ifndef NOMINMAX
#define NOMINMAX
#endif
#include <WinSock2.h>
#endif

Maybe I should open a new issue

[Dysl3xik]

Guys I closed it because I was using the other ZeroMQ CPP project and intended to post there. However this project is probably afflicted the same way.

The issue + PR I issued for that library is here zeromq/zmqpp#233 but the fix there was a tad different because they had an aliased socket type.

If you are experiencing the issue on this library you should re-open this issue and do a PR 👍