Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add - sparkle-effect component #20

Open
3 tasks done
alyhxn opened this issue Apr 1, 2024 · 2 comments
Open
3 tasks done

Add - sparkle-effect component #20

alyhxn opened this issue Apr 1, 2024 · 2 comments

Comments

@alyhxn
Copy link
Collaborator

alyhxn commented Apr 1, 2024

todo

  • Add - sparkle-effect component
@alyhxn
Copy link
Collaborator Author

alyhxn commented Apr 1, 2024

tasks - 2024.04.02

  • Add - sparkle-effect component
    • Added sparkle effect code as given by Serapath - 5min
    • Some changes in code to make it work - 20min
    • Changed import as in feedback - 5min
    • Logged tasks - 5min
    • @output 📦 sparkle_effect_v0.0.1

Worklog

I have not added styling and communication functions as they are not required in any case. So there is almost no change in the code sparkle-effect.


Feedback


Proposal

@serapath
Copy link
Member

serapath commented Apr 2, 2024

feedback 2024.04.02

interesting solution to just require('sparkle-effect/sparkle-effect.js') :-)

you have two othe alternatives so you can just require('sparkle-effect')

  • either make src/node_modules/sparkle-effect/index.js
  • or create src/node_modules/sparkle-effect/package.json and add { "main": "./sparkle-effect.js" }

we usually do the second option, because having many files open named after their component is nicer than having many files in your editor tabs all called index.js :-)


Other than that. Looks great, but one thing I am confused about is, that the pull request you made comes from https://github.com/alyhxn/wizard-amigos-webpage

This page should probably have a README.md that more or less copies and adapts the README from our current website.

Additionally, it has a preview page, but interestingly, the sparkles don't show on that page. Is that page up to date? You might sometimes need to add a commit update bundle.js by running npm run build so browserify creates the latest bundle file for you to commit :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants