Skip to content

Commit ce739a3

Browse files
committed
Disable RQRescoreLimit and use RescoreLimit for all quantizations
1 parent 4b71d46 commit ce739a3

File tree

2 files changed

+4
-7
lines changed

2 files changed

+4
-7
lines changed

benchmarker/cmd/ann_benchmark.go

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -284,7 +284,7 @@ func createSchema(cfg *Config, client *weaviate.Client) {
284284
"dataBits": cfg.RQDataBits,
285285
"queryBits": cfg.RQQueryBits,
286286
"rescore": cfg.RQRescore,
287-
"rescoreLimit": cfg.RQRescoreLimit,
287+
"rescoreLimit": cfg.RescoreLimit,
288288
},
289289
}
290290
}
@@ -377,7 +377,7 @@ func createSchema(cfg *Config, client *weaviate.Client) {
377377
"rqDataBits": cfg.RQDataBits,
378378
"rqQueryBits": cfg.RQQueryBits,
379379
"rescore": cfg.RQRescore,
380-
"rescoreLimit": cfg.RQRescoreLimit,
380+
"rescoreLimit": cfg.RescoreLimit,
381381
},
382382
}
383383
}
@@ -591,7 +591,7 @@ func enableCompression(cfg *Config, client *weaviate.Client, dimensions uint, co
591591
"dataBits": cfg.RQDataBits,
592592
"queryBits": cfg.RQQueryBits,
593593
"rescore": cfg.RQRescore,
594-
"rescoreLimit": cfg.RQRescoreLimit,
594+
"rescoreLimit": cfg.RescoreLimit,
595595
}
596596
}
597597

@@ -1276,7 +1276,7 @@ func initAnnBenchmark() {
12761276
annBenchmarkCommand.PersistentFlags().BoolVar(&globalConfig.Cache,
12771277
"cache", false, "Set cache")
12781278
annBenchmarkCommand.PersistentFlags().IntVar(&globalConfig.RescoreLimit,
1279-
"rescoreLimit", 256, "Rescore limit (default 256) for BQ")
1279+
"rescoreLimit", 256, "Rescore limit (default 256) for BQ. If using RQ, it's recommended to set it to 20")
12801280
annBenchmarkCommand.PersistentFlags().StringVar(&globalConfig.PQ,
12811281
"pq", "disabled", "Set PQ (disabled, auto, or enabled) (default disabled)")
12821282
annBenchmarkCommand.PersistentFlags().StringVar(&globalConfig.SQ,
@@ -1295,8 +1295,6 @@ func initAnnBenchmark() {
12951295
"rqQueryBits", 8, "Set RQ query bit (default 8)")
12961296
annBenchmarkCommand.PersistentFlags().BoolVar(&globalConfig.RQRescore,
12971297
"rqRescore", false, "Skip rescoring for RQ (default true)")
1298-
annBenchmarkCommand.PersistentFlags().UintVar(&globalConfig.RQRescoreLimit,
1299-
"rqRescoreLimit", 20, "Set RQ rescore limit (default 20)")
13001298
annBenchmarkCommand.PersistentFlags().IntVarP(&globalConfig.MultiVectorDimensions,
13011299
"multiVector", "m", 0, "Enable multi-dimensional vectors with the specified number of dimensions")
13021300
annBenchmarkCommand.PersistentFlags().BoolVar(&globalConfig.MuveraEnabled,

benchmarker/cmd/config.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,6 @@ type Config struct {
5151
RQDataBits uint
5252
RQQueryBits uint
5353
RQRescore bool
54-
RQRescoreLimit uint
5554
SkipQuery bool
5655
SkipAsyncReady bool
5756
SkipTombstonesEmpty bool

0 commit comments

Comments
 (0)