Skip to content

Commit 7bd3a1a

Browse files
authored
Merge branch 'v3-alpha' into fix-hidden-menuitem
2 parents d30652a + fe6635c commit 7bd3a1a

File tree

5 files changed

+60
-44
lines changed

5 files changed

+60
-44
lines changed

.github/workflows/build-and-test-v3.yml

+21-14
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ jobs:
9191
strategy:
9292
fail-fast: false
9393
matrix:
94-
os: [warp-windows-latest-x64-2x, warp-macos-15-arm64-6x, warp-ubuntu-latest-x64-2x]
94+
os: [windows-latest, ubuntu-latest, macos-latest]
9595
go-version: [1.24]
9696

9797
steps:
@@ -223,16 +223,23 @@ jobs:
223223
cd ${{ matrix.template }}
224224
wails3 build
225225
226-
results:
227-
if: ${{ always() }}
228-
runs-on: ubuntu-latest
229-
name: v3 Build Results
230-
needs: [test_go, test_js, test_templates]
231-
steps:
232-
- run: |
233-
result="${{ needs.build.result }}"
234-
if [[ $result == "success" || $result == "skipped" ]]; then
235-
exit 0
236-
else
237-
exit 1
238-
fi
226+
results:
227+
if: ${{ always() }}
228+
runs-on: ubuntu-latest
229+
name: v3 Build Results
230+
needs: [test_go, test_js, test_templates]
231+
steps:
232+
- run: |
233+
go_result="${{ needs.test_go.result }}"
234+
js_result="${{ needs.test_js.result }}"
235+
templates_result="${{ needs.test_templates.result }}"
236+
237+
if [[ $go_result == "success" || $go_result == "skipped" ]] && \
238+
[[ $js_result == "success" || $js_result == "skipped" ]] && \
239+
[[ $templates_result == "success" || $templates_result == "skipped" ]]; then
240+
echo "All required jobs succeeded or were skipped"
241+
exit 0
242+
else
243+
echo "One or more required jobs failed"
244+
exit 1
245+
fi

.github/workflows/pr.yml renamed to .github/workflows/pr-v3.yml

+25-26
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,10 @@ on:
88
types: [submitted]
99
branches:
1010
- master
11-
1211
jobs:
1312
check_docs:
1413
name: Check Docs
15-
if: ${{github.repository == 'wailsapp/wails' && contains(github.head_ref,'feature/')}}
14+
if: ${{github.repository == 'wailsapp/wails' && github.base_ref == 'master'}}
1615
runs-on: ubuntu-latest
1716
steps:
1817
- uses: actions/checkout@v3
@@ -30,37 +29,37 @@ jobs:
3029
run: |
3130
echo "::warning::Feature branch does not contain any changes to the website."
3231
33-
# lint_go:
34-
# name: Run Go Linters
35-
# runs-on: ubuntu-latest
36-
# steps:
37-
# - name: Checkout code
38-
# uses: actions/checkout@v4
39-
#
40-
# - name: Setup Go
41-
# uses: actions/setup-go@v4
42-
# with:
43-
# go-version: "1.21"
44-
#
45-
# - name: Update go modules
46-
# working-directory: ./v2
47-
# run: go mod tidy
48-
#
49-
# - name: Run Linter
50-
# uses: golangci/golangci-lint-action@v3
51-
# with:
52-
# version: v1.54
53-
# working-directory: ./v2
54-
# args: --timeout=10m0s --config ./.golangci.yml
32+
# lint_go:
33+
# name: Run Go Linters
34+
# runs-on: ubuntu-latest
35+
# steps:
36+
# - name: Checkout code
37+
# uses: actions/checkout@v4
38+
#
39+
# - name: Setup Go
40+
# uses: actions/setup-go@v4
41+
# with:
42+
# go-version: "1.21"
43+
#
44+
# - name: Update go modules
45+
# working-directory: ./v2
46+
# run: go mod tidy
47+
#
48+
# - name: Run Linter
49+
# uses: golangci/golangci-lint-action@v3
50+
# with:
51+
# version: v1.54
52+
# working-directory: ./v2
53+
# args: --timeout=10m0s --config ./.golangci.yml
5554

5655
test_go:
5756
name: Run Go Tests
5857
runs-on: ${{ matrix.os }}
59-
if: github.event.review.state == 'approved'
58+
if: github.event.review.state == 'approved' && github.repository == 'wailsapp/wails' && github.base_ref == 'master'
6059
strategy:
6160
matrix:
6261
os: [ubuntu-22.04, windows-latest, macos-latest, ubuntu-24.04]
63-
go-version: ['1.21']
62+
go-version: ['1.23']
6463

6564
steps:
6665
- name: Checkout code

docs/src/content/docs/changelog.mdx

+2
Original file line numberDiff line numberDiff line change
@@ -109,6 +109,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
109109
- The dragging and resizing mechanism is now more robust and matches expected platform behaviour more closely by [@fbbdev](https://github.com/fbbdev) in [#4100](https://github.com/wailsapp/wails/pull/4100)
110110
- Fixed [#4097](https://github.com/wailsapp/wails/issues/4097) Webpack/angular discards runtime init code by [@fbbdev](https://github.com/fbbdev) in [#4100](https://github.com/wailsapp/wails/pull/4100)
111111
- Fixed initially-hidden menu items by [@IanVS](https://github.com/IanVS) in [#4116](https://github.com/wailsapp/wails/pull/4116)
112+
- Fixed assetFileServer not serving `.html` files when non-extension request when `[request]` doesn't exist but `[request].html` does
113+
- Fixed icon generation paths by [@robin-samuel](https://github.com/robin-samuel) in [#4125](https://github.com/wailsapp/wails/pull/4125)
112114

113115
### Changed
114116

v3/internal/assetserver/asset_fileserver.go

+9-1
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,15 @@ func (d *assetFileServer) serveFSFile(rw http.ResponseWriter, req *http.Request,
7171

7272
file, err := d.fs.Open(filename)
7373
if err != nil {
74-
return err
74+
if s := path.Ext(filename); s == "" {
75+
filename = filename + ".html"
76+
file, err = d.fs.Open(filename)
77+
if err != nil {
78+
return err
79+
}
80+
} else {
81+
return err
82+
}
7583
}
7684
defer file.Close()
7785

v3/internal/commands/build_assets/Taskfile.tmpl.yml

+3-3
Original file line numberDiff line numberDiff line change
@@ -66,10 +66,10 @@ tasks:
6666
sources:
6767
- "appicon.png"
6868
generates:
69-
- "icons.icns"
70-
- "icons.ico"
69+
- "darwin/icons.icns"
70+
- "windows/icon.ico"
7171
cmds:
72-
- wails3 generate icons -input appicon.png -macfilename darwin/icons.icns -windowsfilename windows/icons.ico
72+
- wails3 generate icons -input appicon.png -macfilename darwin/icons.icns -windowsfilename windows/icon.ico
7373

7474
dev:frontend:
7575
summary: Runs the frontend in development mode

0 commit comments

Comments
 (0)