Skip to content

Commit 662bef4

Browse files
authored
Merge branch 'v3-alpha' into v3-alpha-bugfix/bindgen-build-flags
2 parents 41ea6a4 + 5ccc810 commit 662bef4

File tree

3 files changed

+6
-9
lines changed

3 files changed

+6
-9
lines changed

v3/internal/commands/icons_test.go

+2-5
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ func TestGenerateIcon(t *testing.T) {
4646
},
4747
},
4848
{
49-
name: "should generate a .ico file when using the `input` flag and `windowsfilena me` flag",
49+
name: "should generate a .ico file when using the `input` flag and `windowsfilename` flag",
5050
setup: func() *IconsOptions {
5151
// Get the directory of this file
5252
_, thisFile, _, _ := runtime.Caller(1)
@@ -68,10 +68,7 @@ func TestGenerateIcon(t *testing.T) {
6868
}
6969
defer func() {
7070
// Remove the file
71-
err = os.Remove("appicon.ico")
72-
if err != nil {
73-
return
74-
}
71+
_ = os.Remove("appicon.ico")
7572
}()
7673
if f.IsDir() {
7774
return fmt.Errorf("appicon.ico is a directory")

v3/internal/github/semver_test.go

+3-3
Original file line numberDiff line numberDiff line change
@@ -8,13 +8,13 @@ import (
88
func TestSemanticVersion_IsGreaterThan(t *testing.T) {
99
is2 := is.New(t)
1010

11-
alpha1, err := NewSemanticVersion("v2.0.0-alpha.1")
11+
alpha1, err := NewSemanticVersion("v3.0.0-alpha.1")
1212
is2.NoErr(err)
1313

14-
beta1, err := NewSemanticVersion("v2.0.0-beta.1")
14+
beta1, err := NewSemanticVersion("v3.0.0-beta.1")
1515
is2.NoErr(err)
1616

17-
v2, err := NewSemanticVersion("v2.0.0")
17+
v2, err := NewSemanticVersion("v3.0.0")
1818
is2.NoErr(err)
1919

2020
is2.True(alpha1.IsPreRelease())

v3/internal/templates/templates.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,7 @@ func parseTemplate(template fs.FS, templateName string) (Template, error) {
164164
return result, fmt.Errorf("template not supported by wails 3. This template is probably for wails 2")
165165
}
166166
if result.Schema != 3 {
167-
return result, fmt.Errorf("template version %d is not supported by wails 3. Ensure 'version' is set to 3 in the `template.json` file", result.Version)
167+
return result, fmt.Errorf("template version %s is not supported by wails 3. Ensure 'version' is set to 3 in the `template.json` file", result.Version)
168168
}
169169

170170
return result, nil

0 commit comments

Comments
 (0)