You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Replace ArrayStream with ArrayIterator since the API is blocking. Use ScanBuilder::into_array_iter
Maybe hide file open / scan APIs inside DuckDB feature flag. As in, they're not public API yet since they're not stabilised in Rust even.
Use usize_t instead of uint64_t where usize is used in Rust. Else WASM API gets weird. We also use uint32 in a bunch of places that should also be usize_t, e.g. vx_array_null_count
Improve docs with consistent way of describing ownership.
Seems like we use struct <type_name> everywhere instead of the typedefs?
Perhaps rename vx_array_free and similar functions to _drop, since we often Arc internally it's not true that this call will always trigger a free. Don't mind either way. For Arc we should probably also add vx_T_clone too though.
Options structs should be opaque, with setter function that takes an option enum? Or individual setters? Not sure.
I still don't think we have error handling quite right. When propagating errors, I want to be able to write something like:
#[deny(missing_docs)]
in vortex-ffi/lib.rsvx_nullable_t
to true/false enum.vx_dtype_new
should actually bevx_dtype_new_primitive(vx_ptype_t, nullable_t)
.vx_dtype_get
shoule bevx_dtype_t vx_dtype_variant(const vx_dtype *dtype)
struct <type_name>
everywhere instead of the typedefs?vx_array_free
and similar functions to_drop
, since we often Arc internally it's not true that this call will always trigger a free. Don't mind either way. For Arc we should probably also addvx_T_clone
too though.I still don't think we have error handling quite right. When propagating errors, I want to be able to write something like:
The text was updated successfully, but these errors were encountered: