angular-email-editor@15.2.0 asking for react packages

[joaomsrodrigues21]

Hi,

after upgrade my angular app to @angular/cli@15.2.11 and angular-email-editor to v15.2.0 it is asking for react packages during build:

`Error: node_modules/unlayer-types/embed.d.ts:2823:38 - error TS2307: Cannot find module 'react' or its corresponding type declarations.

2823 import React, { RefObject } from 'react';`

On package-lock.json I have:
"node_modules/angular-email-editor": { "version": "15.2.0", "resolved": "https://registry.npmjs.org/angular-email-editor/-/angular-email-editor-15.2.0.tgz", "integrity": "sha512-vi3LjMgL5uNRi0A59yPf4atJSzZNfrvZuvB6NyA/oA/+Emole1aH9KSZtsq0OhX8N29dZ24oSC5htahbEESWZA==", "dependencies": { "tslib": "^2.3.0" }, "peerDependencies": { "unlayer-types": "^1.33.0" } },

Why is it asking for react packages when I'm using it in angular? Should I install any other packages?

Thank you!

[IndikaWeerakoon]

I’m also facing the same issue after upgrading to angular-email-editor@15.2.0 with @angular/cli@15.2.11. The build fails due to missing React dependencies that required:

Error: node_modules/unlayer-types/embed.d.ts:2027:23 - error TS2307: Cannot find module 'react' or its corresponding type declarations.

2027     import React from 'react';
                           ~~~~~~~

My package-lock.json shows

"node_modules/angular-email-editor": {
      "version": "15.2.0",
      "resolved": "https://registry.npmjs.org/angular-email-editor/-/angular-email-editor-15.2.0.tgz",
      "integrity": "sha512-vi3LjMgL5uNRi0A59yPf4atJSzZNfrvZuvB6NyA/oA/+Emole1aH9KSZtsq0OhX8N29dZ24oSC5htahbEESWZA==",
      "dependencies": {
        "tslib": "^2.3.0"
      },
      "peerDependencies": {
        "unlayer-types": "latest"
      }
    },

It seems unlayer-types is requiring React types, even though this is an Angular project. Looking for a fix or workaround.

Hi @omerzahidbajwa, this issue appears to come from your PR merged in version 15.1.0. Disabling type checking for the entire project isn’t a viable solution. Looking for a proper fix or workaround.

Pull request: #133

[omerzahidbajwa]

Hi, please pass on the following to bypass the typescript errors. (mentioned under readme)

{
"compilerOptions": {
"skipLibCheck": true,
}
}

[IndikaWeerakoon]

Hi, thanks for the suggestion! While skipLibCheck: true can be a temporary workaround, it’s not an ideal long-term solution since it disables type checking across the entire project, which might hide other potential issues.

The core problem is that angular-email-editor, which is meant for Angular, has a dependency on unlayer-types, which requires React types. It would be great if we could find a proper fix for this dependency issue instead of bypassing type checks.

Would love to hear if there's a planned update to address this. Thanks!

[Atom1er]

Same issue here, bypassing types check isn't recommended.