Merge pull request #2 from truefoundry/updating-node-count

Updating node count

Author: dunefro

.github/workflows/tflint.yaml

@@ -0,0 +1,40 @@
+name: Lint
+on:
+  push:
+    branches: [ master ]
+  pull_request:
+
+jobs:
+  tflint:
+    runs-on: ${{ matrix.os }}
+
+    strategy:
+      matrix:
+        os: [ubuntu-latest, macos-latest, windows-latest]
+
+    steps:
+    - uses: actions/checkout@v3
+      name: Checkout source code
+
+    - uses: actions/cache@v3
+      name: Cache plugin dir
+      with:
+        path: ~/.tflint.d/plugins
+        key: ${{ matrix.os }}-tflint-${{ hashFiles('.tflint.hcl') }}
+
+    - uses: terraform-linters/setup-tflint@v3
+      name: Setup TFLint
+      with:
+        tflint_version: v0.47.0
+
+    - name: Show version
+      run: tflint --version
+
+    - name: Init TFLint
+      run: tflint --init
+      env:
+        # https://github.com/terraform-linters/tflint/blob/master/docs/user-guide/plugins.md#avoiding-rate-limiting
+        GITHUB_TOKEN: ${{ github.token }}
+
+    - name: Run TFLint
+      run: tflint --minimum-failure-severity=error -f compact

aks.tf

@@ -25,22 +25,23 @@ module "aks" {
   agents_labels = {
     "truefoundry" : "essential"
   }
-  agents_count     = local.intial_node_pool_instance_count
-  agents_max_count = local.intial_node_pool_instance_count
-  agents_min_count = local.intial_node_pool_instance_count
+  agents_count     = local.intial_node_pool_min_count
+  agents_max_count = local.intial_node_pool_max_count
+  agents_min_count = local.intial_node_pool_min_count
   agents_pool_name = "initial"
   agents_size      = var.intial_node_pool_instance_type
   agents_tags      = local.tags
 
   # autoscaler configuration
   auto_scaler_profile_enabled                          = true
   auto_scaler_profile_expander                         = "random"
+  auto_scaler_profile_max_graceful_termination_sec     = "180"
   auto_scaler_profile_max_node_provisioning_time       = "5m"
   auto_scaler_profile_max_unready_nodes                = 0
-  auto_scaler_profile_scale_down_delay_after_add       = "5m"
+  auto_scaler_profile_scale_down_delay_after_add       = "2m"
   auto_scaler_profile_scale_down_delay_after_delete    = "30s"
   auto_scaler_profile_scale_down_unneeded              = "1m"
-  auto_scaler_profile_scale_down_unready               = "5m"
+  auto_scaler_profile_scale_down_unready               = "2m"
   auto_scaler_profile_scale_down_utilization_threshold = "0.3"
 
   # cluster level configurations

locals.tf

@@ -7,7 +7,8 @@ locals {
     },
     var.tags
   )
-  intial_node_pool_instance_count = var.control_plane ? 2 : 1
+  intial_node_pool_min_count = var.control_plane ? 2 : 1
+  intial_node_pool_max_count = var.control_plane ? 3 : 2
   node_pools = {
     spot = {
       name            = "spotpool"