Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TRI-4372] Errors thrown in onStart should fail the run with that error #1630

Open
matt-aitken opened this issue Jan 22, 2025 · 1 comment · May be fixed by #1640
Open

[TRI-4372] Errors thrown in onStart should fail the run with that error #1630

matt-aitken opened this issue Jan 22, 2025 · 1 comment · May be fixed by #1640

Comments

@matt-aitken
Copy link
Member

matt-aitken commented Jan 22, 2025 •
edited
Loading

As we currently state in our docs:

Errors thrown in the onStart function are ignored.

However, I think this is the wrong behaviour. It should fail with the error.

TRI-4372
@matt-aitken matt-aitken changed the title Errors thrown in onStart should fail the run with that error [TRI-4372] Errors thrown in onStart should fail the run with that error Jan 22, 2025
@Pratik-Mahajan257
Copy link

Pratik-Mahajan257 commented Jan 25, 2025 •
edited
Loading

hey @matt-aitken Can you please assign this to me? this is my first time doing contribution to OS world. I would love to try to fix this.

@Pratik-Mahajan257 Pratik-Mahajan257 linked a pull request Jan 26, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat : Errors thrown in onStart should fail the run with that error Pratik-Mahajan257/trigger.dev
2 participants
@matt-aitken @Pratik-Mahajan257