Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: ShellPkg: ARMV9 support should be added to SmbioView command based on Type 4 processor information. #10723

Open
2 of 5 tasks
praveensankarn opened this issue Feb 5, 2025 · 3 comments
Labels
package:shellpkg priority:medium Moderate impact. Should be prioritized over lower priority issues. state:needs-maintainer-feedback state:needs-triage type:bug Something isn't working

Comments

@praveensankarn
Copy link
Contributor

Is there an existing issue for this?

  • I have searched existing issues

Bug Type

  • Firmware
  • Tool
  • Unit Test

Code first?

  • Yes

What packages are impacted?

ShellPkg

Which targets are impacted by this bug?

No response

Current Behavior

If the processor family is ArmV9 based processor, then shell shows "Undefined processor family and type" against the field "Processor Family 2 : ", whenever the below command is passed in shell.
smbiosview -t 4.

Expected Behavior

The processor family should be shown as ARMV9 while executing "smbiosview -t 4" command in shell.

Steps To Reproduce

  1. Build the code.
  2. Flash the image and boot to shell
  3. Execute smbiosview -t 4 command in shell prompt.
  4. See the error "Undefined processor family" against Processor Family 2 : field.

Build Environment

- OS(s):Windows or Ubuntu
- Tool Chain(s):GCC5 or VS2019 or VS2015.

Version Information

edk2-stable202411

Urgency

Medium

Are you going to fix this?

I will fix it

Do you need maintainer feedback?

Maintainer feedback requested

Anything else?

Hi @lgao4 @mdkinney @pierregondois
Added switch case for ArmV9 processor family inside function DisplayProcessorFamily2 in PrintInfo.c to avoid inappropriate data shown for ArmV9 processors. ArmV9 processor family is added in Smbios 3.8 specification, which should be noted as well. I will push the local branch here to review the changes.

Thanks,
Praveen Sankar

@praveensankarn praveensankarn added state:needs-triage type:bug Something isn't working labels Feb 5, 2025
@github-actions github-actions bot added package:shellpkg priority:medium Moderate impact. Should be prioritized over lower priority issues. state:needs-maintainer-feedback labels Feb 5, 2025
@praveensankarn
Copy link
Contributor Author

Hi @lgao4 @mdkinney,
I got permission denied error while pushing local branch (which has changes made for the fix). Could you please help me with this ?

Thanks,
Praveen Sankar

@pierregondois
Copy link
Contributor

Hello Praveen,
if you are trying to push a branch on the tianocore edk2 github repository, I think this is normal to have a permission denied error. You should create a branch on a fork of the edk2 repository and then make a pull request of that branch on the tianocore edk2 repository.
For more information, the following page should help: https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process

@praveensankarn
Copy link
Contributor Author

Hi @pierregondois,
Created the pull requested, as you said. URL for PR has been given below for your reference.
https://github.com/tianocore/edk2/pull/10726

Thanks,
Praveen Sankar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:shellpkg priority:medium Moderate impact. Should be prioritized over lower priority issues. state:needs-maintainer-feedback state:needs-triage type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants