Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Names not applying #216

Closed
guybedford opened this issue Oct 28, 2024 · 2 comments
Closed

Names not applying #216

guybedford opened this issue Oct 28, 2024 · 2 comments

Comments

@guybedford
Copy link
Contributor

I just tried the latest 0.1.4 and it seems the "name" section isn't being transformed properly.

I think the simplest approach here to test this is by running wasm-tools print out.wasm -o out.wat and checking that the functions still have their correct names in that output. For the transformations we are doing in ComponentizeJS this is unfortunately still not the case.

@thesuhas
Copy link
Owner

Hi,
Can you provide me with a sample input and output .wasm, and the command you're running ComponentizeJS with so that I can hunt down the issue?

@guybedford
Copy link
Contributor Author

Looking into this further the issue might be in wasm-opt itself since the build output for StarlingMonkey under RelWithDebInfo isn't printing names either. Will reopen if I find the root of that, but for now moving to - bytecodealliance/StarlingMonkey#173 for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants