Skip to content

testLineSequence is flaky, at least on Linux #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jakepetroules opened this issue Jun 13, 2025 · 3 comments
Open

testLineSequence is flaky, at least on Linux #78

jakepetroules opened this issue Jun 13, 2025 · 3 comments
Labels
bug Something isn't working

Comments

@jakepetroules
Copy link
Contributor

testLineSequence occasionally fails on Linux. See attached test output which was from a run with nightly-main jammy on GitHub actions CI.

job-logs.txt

@jakepetroules jakepetroules added the bug Something isn't working label Jun 13, 2025
@jakepetroules
Copy link
Contributor Author

Oddly I've never seen this fail on Darwin, but seems to happen quite often in Linux containers.

@jakepetroules
Copy link
Contributor Author

jakepetroules commented Jun 13, 2025

One issue is that generateString shouldn't ever return an empty buffer, because a line ending with \r\n is indistinguishable from a line ending with \r followed by an empty line ending with \n. That's not the only problem though.

@jakepetroules
Copy link
Contributor Author

Linux buffer size is 4096, macOS is 16384. I think on Linux we're getting unlucky that the middle of a newline sequence is right on the boundary of a multiple of a buffer size and thus we complete a line too early.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant