-
Notifications
You must be signed in to change notification settings - Fork 96
Allow ISbLinksParams
to StoryblokClient.getAll
method
#944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
shabab477
added a commit
to shabab477/storyblok-js-client
that referenced
this issue
Mar 4, 2025
Problem: - Developers may need to `getAll` when getting an unpaginated response from `cdn/links` Solution: - Extend interface of IsbStoriesParam with ISbLinksParams on getAll call signature Closes: storyblok#944
5 tasks
shabab477
added a commit
to shabab477/storyblok-js-client
that referenced
this issue
Mar 16, 2025
…ksParams Problem: - Developers may need to `getAll` when getting an unpaginated response from `cdn/links` - Currently when calling `cdn/links` with ISbLinksParams results with compile time error when using ISbLinksParams specific params like: include_dates Solution: - Make `getAll` function generic to make it type aware of the intention of the developer - Updated the function to not allow developers to modify the number of round trips for fetching all results - Updated unit tests and e2e tests Closes: storyblok#944
shabab477
added a commit
to shabab477/storyblok-js-client
that referenced
this issue
Mar 16, 2025
…ksParams Problem: - Developers may need to `getAll` when getting an unpaginated response from `cdn/links` - Currently when calling `cdn/links` with ISbLinksParams results with compile time error when using ISbLinksParams specific params like: include_dates Solution: - Make `getAll` function generic to make it type aware of the intention of the developer - Updated the function to not allow developers to modify the number of round trips for fetching all results - Updated unit tests and e2e tests Closes: storyblok#944
shabab477
added a commit
to shabab477/storyblok-js-client
that referenced
this issue
Mar 22, 2025
…ksParams Problem: - Developers may need to `getAll` when getting an unpaginated response from `cdn/links` - Currently when calling `cdn/links` with ISbLinksParams results with compile time error when using ISbLinksParams specific params like: include_dates Solution: - Make `getAll` function generic to make it type aware of the intention of the developer - Updated unit tests and e2e tests Closes: storyblok#944
shabab477
added a commit
to shabab477/storyblok-js-client
that referenced
this issue
Mar 22, 2025
…ksParams Problem: - Developers may need to `getAll` when getting an unpaginated response from `cdn/links` - Currently when calling `cdn/links` with ISbLinksParams results with compile time error when using ISbLinksParams specific params like: include_dates Solution: - Make `getAll` function generic to make it type aware of the intention of the developer - Updated unit tests and e2e tests Closes: storyblok#944
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
StoryblokClient#getAll
method supports params forISbStoryData
,ISbMultipleStoriesData
,ISbAssetsParams
but not params forISbLinksParams
. This is a big problem because for creating sitemaps withlastmod
elements.Expected Behavior
Current Behavior
Steps to Reproduce
See current behavior
Note:
get
method is overloaded correctly.getAll
method.include_dates
to be allowed.The text was updated successfully, but these errors were encountered: