Refactored SqlServer's SucceedFunction SqlGenerator-method

Author: stidsborg

Stores/SqlServer/Cleipnir.ResilientFunctions.SqlServer/SqlGenerator.cs

@@ -166,9 +166,7 @@ public string CreateFunction(
     }
 
     private string? _succeedFunctionSql;
-    public string SucceedFunction(
-        StoredId storedId, byte[]? result, long timestamp, int expectedEpoch,
-        SqlCommand command, string paramPrefix)
+    public StoreCommand SucceedFunction(StoredId storedId, byte[]? result, long timestamp, int expectedEpoch, string paramPrefix)
     {
         _succeedFunctionSql ??= @$"
             UPDATE {tablePrefix}
@@ -178,14 +176,15 @@ public string SucceedFunction(
         var sql = paramPrefix == "" 
             ? _succeedFunctionSql
             : _succeedFunctionSql.Replace("@", $"@{paramPrefix}");
-        
-        command.Parameters.AddWithValue($"@{paramPrefix}ResultJson", result ?? SqlBinary.Null);
-        command.Parameters.AddWithValue($"@{paramPrefix}Timestamp", timestamp);
-        command.Parameters.AddWithValue($"@{paramPrefix}FlowInstance", storedId.Instance.Value);
-        command.Parameters.AddWithValue($"@{paramPrefix}FlowType", storedId.Type.Value);
-        command.Parameters.AddWithValue($"@{paramPrefix}ExpectedEpoch", expectedEpoch);
 
-        return sql;
+        var command = new StoreCommand(sql);
+        command.AddParameter($"@{paramPrefix}ResultJson", result ?? SqlBinary.Null);
+        command.AddParameter($"@{paramPrefix}Timestamp", timestamp);
+        command.AddParameter($"@{paramPrefix}FlowInstance", storedId.Instance.Value);
+        command.AddParameter($"@{paramPrefix}FlowType", storedId.Type.Value);
+        command.AddParameter($"@{paramPrefix}ExpectedEpoch", expectedEpoch);
+
+        return command;
     }
 
     private string? _postponedFunctionSql;

Stores/SqlServer/Cleipnir.ResilientFunctions.SqlServer/SqlServerFunctionStore.cs

@@ -393,18 +393,14 @@ public async Task<bool> SucceedFunction(
         ComplimentaryState complimentaryState)
     {
         await using var conn = await _connFunc();
-        await using var command = new SqlCommand();
-        command.Connection = conn;
-        
-        var sql = _sqlGenerator.SucceedFunction(
-            storedId,
-            result,
-            timestamp,
-            expectedEpoch,
-            command,
-            paramPrefix: ""
-        );
-        command.CommandText = sql;
+        await using var command = _sqlGenerator
+            .SucceedFunction(
+                storedId,
+                result,
+                timestamp,
+                expectedEpoch,
+                paramPrefix: ""
+            ).ToSqlCommand(conn);
 
         var affectedRows = await command.ExecuteNonQueryAsync();
         return affectedRows > 0;