Removed SuspendUntilCompletion reactive operator

Author: stidsborg

Core/Cleipnir.ResilientFunctions.Tests/ReactiveTests/LeafOperatorsTests.cs

@@ -463,7 +463,7 @@ public void CompletionOperatorWithSuspensionCompletesImmediatelyOnCompletedStrea
 
         source.SignalNext(1, new InterruptCount(1));
         source.SignalNext(2, new InterruptCount(2));
-        var completionOrSuspend = source.OfType<int>().Take(1).SuspendUntilCompletion();
+        var completionOrSuspend = source.OfType<int>().Take(1).Completion(maxWait: TimeSpan.Zero);
 
         completionOrSuspend.IsCompletedSuccessfully.ShouldBeTrue();
     }
@@ -476,7 +476,7 @@ public async Task CompletionOperatorWithSuspensionAndTimeoutSucceedsWithImmediat
         var stopWatch = new Stopwatch();
         stopWatch.Start();
 
-        var nextOrSuspend = source.SuspendUntilCompletion(maxWait: TimeSpan.FromSeconds(1));
+        var nextOrSuspend = source.Completion(maxWait: TimeSpan.FromSeconds(1));
         source.SignalNext(1, new InterruptCount(1));
         source.SignalNext(2, new InterruptCount(2));
 
@@ -495,7 +495,7 @@ public async Task CompletionOperatorWithSuspensionAndTimeoutThrowsSuspensionExce
     {
         var source = new Source(NoOpTimeoutProvider.Instance);
 
-        var nextOrSuspend = source.SuspendUntilCompletion(maxWait: TimeSpan.FromMilliseconds(100));
+        var nextOrSuspend = source.Completion(maxWait: TimeSpan.FromMilliseconds(100));
 
         await Should.ThrowAsync<SuspendInvocationException>(nextOrSuspend);
     }
@@ -506,7 +506,7 @@ public async Task CompletionOperatorWithSuspensionThrowsSuspensionExceptionWhenN
         var source = new Source(NoOpTimeoutProvider.Instance);
 
         await Should.ThrowAsync<SuspendInvocationException>(
-            () => source.OfType<int>().SuspendUntilCompletion()
+            () => source.OfType<int>().Completion(maxWait: TimeSpan.Zero)
         );
     }
 

Core/Cleipnir.ResilientFunctions.Tests/TestTemplates/RFunctionTests/SuspensionTests.cs

@@ -382,7 +382,7 @@ protected async Task StartedChildActionInvocationPublishesResultSuccessfully(Tas
                 await child.Schedule("SomeChildInstance#1", "hallo world");
                 await child.Schedule("SomeChildInstance#2", "hallo world");
 
-                await workflow.Messages.Take(2).SuspendUntilCompletion();
+                await workflow.Messages.Take(2).Completion(maxWait: TimeSpan.Zero);
             }
         );
 
@@ -432,7 +432,7 @@ await workflow.Effect.Capture("ScheduleChildren", async () =>
                 var messages = await workflow.Messages
                     .Take(numberOfChildren)
                     .Select(m => m.ToString()!)
-                    .SuspendUntilCompletion();
+                    .Completion(maxWait: TimeSpan.Zero);
 
                 return messages;
             }

Core/Cleipnir.ResilientFunctions/Reactive/Extensions/LeafOperators.cs

@@ -53,15 +53,8 @@ public static async Task<List<T>> ToList<T>(this IReactiveChain<T> s, TimeSpan?
         throw new SuspendInvocationException(interruptCount);
     }
 
-    #region Completion
-
-    public static Task<List<T>> SuspendUntilCompletion<T>(this IReactiveChain<T> s, TimeSpan? maxWait = null)
-        => s.ToList(maxWait ?? TimeSpan.Zero);
-    
     public static Task<List<T>> Completion<T>(this IReactiveChain<T> s, TimeSpan? maxWait = null)
-        => s.ToList();
-    
-    #endregion
+        => s.ToList(maxWait);
 
     internal static List<T> Existing<T>(this IReactiveChain<T> s, out bool streamCompleted)
     {

Samples/Sample.ConsoleApp/LoanApproval/MessagingApproach/ApproveLoan.cs

@@ -16,7 +16,7 @@ public static async Task Execute(LoanApplication loanApplication, Workflow workf
             .OfType<CreditCheckOutcome>()
             .Take(3)
             .TakeUntilTimeout("TimeoutId", expiresAt: loanApplication.Created.AddMinutes(15))
-            .SuspendUntilCompletion();
+            .Completion();
 
         if (outcomes.Count < 2)
             await MessageBroker.Send(new LoanApplicationRejected(loanApplication));

Samples/Sample.ConsoleApp/WorkDistribution/ProcessOrders.cs

@@ -37,7 +37,7 @@ await effect.Capture(
         await messages
             .OfType<FunctionCompletion<string>>()
             .Take(orderIds.Count)
-            .SuspendUntilCompletion();
+            .Completion();
 
         await effect.Capture(
             "Log_ProcessingFinished",