Skip to content

Commit 777aa30

Browse files
author
Miguel Boing
committedJan 16, 2025
firmware: drivers: spi_slave: Minor improvements for code readabily and performance #166
1 parent 1fd3f00 commit 777aa30

File tree

1 file changed

+5
-16
lines changed

1 file changed

+5
-16
lines changed
 

‎firmware/drivers/spi_slave/spi_slave.c

Lines changed: 5 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -81,8 +81,7 @@ static int spi_read_isr_rx_buffer(spi_port_t port, uint8_t *data, uint16_t len);
8181

8282
static int spi_slave_setup_gpio(spi_port_t port);
8383

84-
#define DMA_TX_TRANSFER_SIZE 8
85-
#define DMA_RX_TRANSFER_SIZE 8
84+
#define DMA_TRANSFER_SIZE 8
8685

8786
static uint8_t spi_slave_dma_tx_data[230U] = {0};
8887
static uint8_t spi_slave_dma_rx_data[230U] = {0};
@@ -100,7 +99,7 @@ int spi_slave_init(spi_port_t port, spi_config_t config)
10099
static DMA_initParam spi_slave_dma_param_tx = {
101100
.channelSelect = DMA_CHANNEL_0,
102101
.transferModeSelect = DMA_TRANSFER_REPEATED_SINGLE,
103-
.transferSize = DMA_TX_TRANSFER_SIZE,
102+
.transferSize = DMA_TRANSFER_SIZE,
104103
.triggerSourceSelect = DMA_TRIGGERSOURCE_13,
105104
.transferUnitSelect = DMA_SIZE_SRCBYTE_DSTBYTE,
106105
.triggerTypeSelect = DMA_TRIGGER_HIGH,
@@ -109,7 +108,7 @@ int spi_slave_init(spi_port_t port, spi_config_t config)
109108
static DMA_initParam spi_slave_dma_param_rx = {
110109
.channelSelect = DMA_CHANNEL_1,
111110
.transferModeSelect = DMA_TRANSFER_REPEATED_SINGLE,
112-
.transferSize = DMA_RX_TRANSFER_SIZE,
111+
.transferSize = DMA_TRANSFER_SIZE,
113112
.triggerSourceSelect = DMA_TRIGGERSOURCE_12,
114113
.transferUnitSelect = DMA_SIZE_SRCBYTE_DSTBYTE,
115114
.triggerTypeSelect = DMA_TRIGGER_HIGH,
@@ -309,23 +308,13 @@ int spi_slave_init(spi_port_t port, spi_config_t config)
309308

310309
DMA_enableTransfers(DMA_CHANNEL_0);
311310

312-
for(i = 0U; i < (uint8_t) DMA_RX_TRANSFER_SIZE; i++)
311+
for(i = 0U; i < (uint8_t) DMA_TRANSFER_SIZE; i++)
313312
{
314313
spi_slave_dma_rx_data[i] = 0xFFU;
315-
}
316-
317-
for(i = 0U; i < (uint8_t) DMA_TX_TRANSFER_SIZE; i++)
318-
{
319-
spi_slave_dma_tx_data[i] = 0xFFU;
314+
spi_slave_dma_tx_data[i] = 0x00U;
320315
}
321316

322317
spi_slave_dma_tx_data[0] = 0x7EU;
323-
spi_slave_dma_tx_data[1] = 0x00U;
324-
spi_slave_dma_tx_data[2] = 0x00U;
325-
spi_slave_dma_tx_data[3] = 0x00U;
326-
spi_slave_dma_tx_data[4] = 0x00U;
327-
spi_slave_dma_tx_data[5] = 0x00U;
328-
spi_slave_dma_tx_data[6] = 0x00U;
329318

330319
DMA_init(&spi_slave_dma_param_rx);
331320

0 commit comments

Comments
 (0)
Please sign in to comment.