Skip to content

Commit 210eb32

Browse files
committed
Update TODO
1 parent 14e3ae8 commit 210eb32

File tree

1 file changed

+1
-7
lines changed

1 file changed

+1
-7
lines changed

TODO.md

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -11,15 +11,9 @@ In-Memory Order Updater TODO
1111
- [x] ~Write the `InMemoryOrderAdjuster` (also, should we rename this to `InMemoryOrderPromotionAdjuster`)~
1212
- [x] Fix CI failures from previous session (if any)
1313
- [ ] Add high level test for manipulative queries around new Promotion system
14-
- [WIP] Add high level test for manipulative queries around Legacy Promotion system
15-
- The order updater patch doesn't seem to be loaded no matter which order updater we're using.
16-
- Let's put a breakpoint in the dummy app to make sure all the of autoloaded paths that we expect are there. We put a breakpoint inside of Flickwerk and it showed that it was adding autoload paths to an empty array so we want to be sure that those are not being overwritten somewhere.
14+
- [x] Add high level test for manipulative queries around Legacy Promotion system
1715
- [ ] Adding shared examples that could be used in both promotion system gems to
1816
ensure the above?
19-
- [ ] Failing tests in new promotion system integrations spec due to
20-
legacy_promotions order updater patch in `SolidusLegacyPromotions::SpreeOrderUpdaterPatch`
21-
- [ ] Consider moving the `adjustment_total` re-calculation into the
22-
`Spree::Config.item_total_class` and thus removing the need for the override?
2317
- [In Progress] Handle persistence in all implementations of `promotions.order_adjuster_class`
2418
- [x] Follow up on any failing test relating to change in promotion chooser
2519
- [x] Ensure adjustments are marked for destructions instead of destroyed

0 commit comments

Comments
 (0)