Skip to content

Commit 60ed3d2

Browse files
authored
Merge pull request #47 from fuero/feat/fixes-docs
Adds clarification to docs, fixes typo, uses correct selector
2 parents 7410b0f + 5f8c697 commit 60ed3d2

File tree

1 file changed

+8
-3
lines changed

1 file changed

+8
-3
lines changed

README.md

+8-3
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,11 @@ When the cert-manager has been installed, deploy the helm chart on your machine
6262
export DOMAIN=acme.mydomain.com # replace with your domain
6363
helm install -n cert-manager godaddy-webhook ./deploy/charts/godaddy-webhook --set groupName=$DOMAIN
6464
```
65+
66+
The `groupName` refers to a prior nonexistant Kubernetes API Group, under which custom resources are created.
67+
The name itself has no connection to the domain names for which certificates are issued, and using the default of
68+
`acme.mycompany.com` is fine.
69+
6570
**NOTE**: The kubernetes resources used to install the Webhook should be deployed within the same namespace as the cert-manager.
6671

6772
- To change one of the values, create a `my-values.yml` file or set the value(s) using helm's `--set` argument:
@@ -122,7 +127,7 @@ kubectl apply -f secret.yml -n <NAMESPACE>
122127

123128
### ClusterIssuer
124129

125-
- Create a `ClusterIssuer`resource to specify the address of the ACME staging or production server to access.
130+
- Create a `ClusterIssuer` resource to specify the address of the ACME staging or production server to access.
126131
Add the DNS01 Solver Config that this webhook will use to communicate with the API of the Godaddy Server in order to create
127132
or delete an ACME Challenge TXT record that the DNS Provider will accept/refuse if the domain name exists.
128133

@@ -144,8 +149,8 @@ spec:
144149
name: letsencrypt-<ENV> # staging or production
145150
solvers:
146151
- selector:
147-
dnsNames:
148-
- '*.example.com'
152+
dnsZones:
153+
- 'example.com'
149154
dns01:
150155
webhook:
151156
config:

0 commit comments

Comments
 (0)