Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge implementation with crossbeam-queue #50

Open
notgull opened this issue Aug 29, 2023 · 2 comments
Open

Merge implementation with crossbeam-queue #50

notgull opened this issue Aug 29, 2023 · 2 comments

Comments

@notgull
Copy link
Member

notgull commented Aug 29, 2023

From a brief glance at both crates, it seems to me that there is very little noticeable difference between the algorithm used in concurrent-queue and the one used in crossbeam-queue. It would be nice to just re-implement concurrent-queue in terms of crossbeam-queue if there are no/little significant differences between the two implementations, as it would deduplicate code in the Rust ecosystem.
@taiki-e
Copy link
Collaborator

taiki-e commented Mar 24, 2024

IIRC, the main difference is the presence of code for the single-capacity cases (see also crossbeam-rs/crossbeam#199 (comment)) and disconnect(close) support.

@notgull notgull mentioned this issue Apr 14, 2024
Merged
@taiki-e
Copy link
Collaborator

taiki-e commented Apr 23, 2024

I think there may also be a few optimizations that are present in crossbeam but not in concurrent-queue, such as crossbeam-rs/crossbeam#1057.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@notgull @taiki-e