Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Construction of buffer with vector struct type results in incorrect size #169

Open
ccummingsNV opened this issue Jan 29, 2025 · 0 comments
Assignees

Comments

@ccummingsNV
Copy link
Collaborator

Buffer construction when provided a struct type executes following code:

// Derive struct size from struct type. if (m_desc.struct_type) { ref<const TypeLayoutReflection> type = m_desc.struct_type->unwrap_array(); if (type->element_type_layout()) type = type->element_type_layout(); SGL_CHECK(type, "Invalid struct type."); m_desc.struct_size = type->stride(); m_desc.struct_type = nullptr; }

This fails for vectors and finds the actual scalar type. Need to fix up but not sure what the intended behaviour is in the case of other types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants