Skip to content

Waveforms Should Be URLs #508

Open
@danpastori

Description

@danpastori
Contributor

Discussed in #507

Originally posted by danpastori May 4, 2022

👉 Describe the problem

When generating a waveform, the audio file is loaded twice or is only loaded up to what is buffered. This leads to terrible UI since it's either two requests, or partially shown.

👥 Problem evidence & reach

Any user working with waveforms.

🥰 Describe the "impact" on users?

When displaying a waveform, we should allow the user to pass in a URL. We can generate waveforms using Amplitude Hosting and these will be SVGs making for much speedier, responsive players.

🏆 How to solve this problem

Allow for a waveform to be a URL for the audio file and encourage this. We will remove all waveform generating functionality and abstract it to a plugin. This will be a breaking change, but will lead to much cleaner code, smaller compiled sizes, and better UX.

💯 How do we validate the problem is solved?

A user can generate a waveform through Amplitude Hosting or their own provider and pass it along with an audio file so it loads instantly.

Activity

self-assigned this
on May 4, 2022
moved this to Ready for Development in AmplitudeJS 6.0on May 4, 2022
linked a pull request that will close this issueAmplitudeJS v6.0.0 #514on Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

Status

Ready for Development

Milestone

No milestone

Relationships

None yet

    Development

    Participants

    @danpastori

    Issue actions

      Waveforms Should Be URLs · Issue #508 · serversideup/amplitudejs