Skip to content

Dry-check should check for minimum write access to <repo> in bors.<repo>.review = true #1842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jieyouxu opened this issue May 24, 2025 · 2 comments
Labels
enhancement New feature or request

Comments

@jieyouxu
Copy link
Member

See e.g.#1841

If a team has bors.rust.review = true, they can r+ PRs on rust-lang/rust. Surely if they can r+ PRs they should at the minimum have write access to said repo? Otherwise, the team won't even have triaging perms.

@jieyouxu jieyouxu added the enhancement New feature or request label May 24, 2025
@jieyouxu
Copy link
Member Author

(Note: I'm not sure what coherence checks this repo has)

@Kobzol
Copy link
Contributor

Kobzol commented May 26, 2025

Hmm, I guess the issue is that bors permissions are kind of opaque to team. It treats rust as just an arbitrary string, and there's no connection to the rust-lang/rust repository in team. I guess that we could hardcode it though.

Also I wanted to move the bors permissions from teams/users to the repository itself, to make it clearer who has permissions for a given repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants