Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port tests to use the intrinsic macro #136021

Closed
vayunbiyani opened this issue Jan 24, 2025 · 4 comments
Closed

Port tests to use the intrinsic macro #136021

vayunbiyani opened this issue Jan 24, 2025 · 4 comments
Assignees
@vayunbiyani
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup.

Comments

@vayunbiyani
Copy link
Contributor

vayunbiyani commented Jan 24, 2025 •
edited by rustbot
Loading

tests/ui/simd has a bunch of test cases that need porting, I would suggest those be ported in a separate PR before we do the final big PR that removes support for this ABI from the compiler entirely.

Originally posted by @RalfJung in #132735
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Jan 24, 2025
@vayunbiyani
Copy link
Contributor Author

@rustbot claim

@vayunbiyani vayunbiyani mentioned this issue Jan 24, 2025
Open
@RalfJung
Copy link
Member

I am confused by this issue.

@jieyouxu jieyouxu added C-cleanup Category: PRs that clean code up or issues documenting cleanup. and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Jan 25, 2025
@vayunbiyani
Copy link
Contributor Author

@RalfJung I thought breaking down the larger issue into smaller subtasks might be helpful. What would be the best practice here?

@RalfJung
Copy link
Member

RalfJung commented Feb 3, 2025

#132735 is already breaking things down in subtasks. We don't really need a separate issue for each subtasks when the tasks are as simple as they are here.

I'll close this in favor of #132735 then. :)

@RalfJung RalfJung closed this as completed Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vayunbiyani vayunbiyani

Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@RalfJung @jieyouxu @rustbot @vayunbiyani