Complex use of Vec/VecDeque remove

[paolobarbolini]

What it does

Detect uses of Vec::remove or VecDeque::remove when Vec::pop, VecDeque::pop_front or VecDeque::pop_back could have been used

Advantage

• Makes the code easier to read
• Possibly makes the code run faster

Drawbacks

• In the case of Vec::remove it would break code because it changes the return type from T to Option<T>

Example

vec.remove(vec.len() - 1);

vec_deque.remove(0);
vec_deque.remove(vec_deque.len() - 1);

Could be written as:

vec.pop();

vec_deque.pop_front();
vec_deque.pop_back();

[samueltardieu]

Not only the type changes from T to Option<T>, but that makes fallible code infallible: if for any reason this part of code is given an bogusly empty Vec or VecDeque, it will continue executing instead of panicking which may not be a good idea.

A more similar substitution would be to use vec.pop().unwrap() for example, but isn't that a bit heavy?