Skip to content

Commit c95ba3d

Browse files
author
Roger Strain
committed
Minor updates per feedback.
Distro A; OPSEC #2893 Signed-off-by: Roger Strain <[email protected]>
1 parent 476a6df commit c95ba3d

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

articles/execute_process_refactor.md

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -387,7 +387,7 @@ Most parameters would be passed to the superclass.
387387

388388
|Argument|Description|
389389
|---|---|
390-
| package | Optional. Name of the ROS package the node plugin lives in. If not specified, the package of the containing executable will be assumed. |
390+
| package | Optional. Name of the ROS package the node plugin lives in. If not specified, the package of the containing executable will be assumed. This may fail if context regarding the executable is not available. |
391391
|node_plugin|Name of the plugin to be loaded|
392392

393393
Additional parameters that may be passed, which are handled by `launch_ros.descriptions.NodeBase`: `node_name`, `node_namespace`, `parameters`, `remappings`, `arguments`, `traits`.
@@ -496,11 +496,10 @@ It would not include execution-time details, nor provide monitoring of the proce
496496
| Argument | Description |
497497
| --------------- | ------------------------------------------------------------ |
498498
| package | name of the ROS package the node executable lives in |
499-
|node_executable|Name of the executable to find|
499+
| executable_name |Name of the executable to find|
500500
| nodes | A list of `launch_ros.descriptions.Node` objects which are part of the executable. |
501501

502-
Additional parameters that may be passed, which are handled by `launch.actions.ExecuteProcess`: `cmd`, `name`, `cwd`, `env`, `additional_env`.
503-
NOTE: To allow ROS to determine the appropriate executable based on the package and executable name, the `cmd` parameter should *NOT* be specified. When `cmd` is not specified, this class will determine the appropriate executable if and only if exactly one of the nodes it contains has the `launch_ros.traits.IsExecutable` trait.
502+
Additional parameters that may be passed, which are handled by `launch.actions.Executable`: `name`, `cwd`, `env`, `additional_env`.
504503

505504
#### Properties
506505

0 commit comments

Comments
 (0)