Address CRAN reviewer indications

Author: ranghetti

DESCRIPTION

@@ -1,5 +1,5 @@
 Package: MODIStsp
-Title: A Tool for Automating Download and Preprocessing of MODIS Land Products
+Title: Find, Download and Process MODIS Land Products
     Data
 Type: Package
 Version: 2.0.5
@@ -17,22 +17,28 @@ Authors@R: c(person("Lorenzo", "Busetto",
              person("Jeff", "Hanson", 
                  role = "rev",
                  comment = "Jeff Hanson reviewed the package for rOpenSci, see 
-                     https://github.com/ropensci/software-review/issues/184"))
+                     https://github.com/ropensci/software-review/issues/184"),
+             person("Babak", "Naimi", 
+                 role = "ctb",
+                 comment = "Babak Naimi wrote the function ModisDownload(),
+                     on which some MODIStsp internal functions are based"))
 Description: Allows automating the creation of time series of rasters derived
-    from MODIS Satellite Land Products data. It performs several typical
-    preprocessing steps such as download, mosaicking, reprojection and resize
-    of data acquired on a specified time period. All processing parameters
+    from MODIS satellite land products data. It performs several typical
+    preprocessing steps such as download, mosaicking, reprojecting and resizing
+    data acquired on a specified time period. All processing parameters
     can be set using a user-friendly GUI. Users can select which layers of
     the original MODIS HDF files they want to process, which additional
-    Quality Indicators should be extracted from aggregated MODIS Quality
-    Assurance layers and, in the case of Surface Reflectance products
-    , which Spectral Indexes should be computed from the original reflectance
+    quality indicators should be extracted from aggregated MODIS quality
+    assurance layers and, in the case of surface reflectance products,
+    which spectral indexes should be computed from the original reflectance
     bands. For each output layer, outputs are saved as single-band raster
     files corresponding to each available acquisition date. Virtual files
     allowing access to the entire time series as a single file are also created.
     Command-line execution exploiting a previously saved processing options
-    file is also possible, allowing to automatically update time series
+    file is also possible, allowing users to automatically update time series
     related to a MODIS product whenever a new image is available.
+    For additional documentation refer to the following article: 
+    Busetto and Ranghetti (2016) <doi:10.1016/j.cageo.2016.08.020>.
 License: GPL-3
 Depends:
     R (>= 3.5.0)

NEWS.md

@@ -5,6 +5,9 @@
 - Edit documentation related to the change of maintainer
     (see https://docs.ropensci.org/MODIStsp/articles/lorenzo).
 
+- Add the argument `parallel` to function `MODIStsp()` and `MODSIStsp_process()`
+    to allow running the processing in single core modality.
+    
 ### Minor changes
 
 - Fix Travis tests

R/get_mod_dirs.R

@@ -16,7 +16,7 @@
 #'   environment or not. If not, processing messages are sent to a log file
 #'   instead than to the console/GTK progress windows.
 #' @param out_folder_mod  `character` output folder for MODIS HDF storage
-#' @return `character arraay` listing all available folders (a.k.a. dates) for
+#' @return `character array` listing all available folders (a.k.a. dates) for
 #'   the requested MODIS product on lpdaac http archive, for the years
 #'   included in the time range selected for processing.
 #' @author Original code by Babak Naimi (\code{.getModisList}, in

README.Rmd

@@ -63,7 +63,10 @@ For more information, documentation and examples of use, __see also the `{MODISt
 
 ## Important News
 
-- 09/02/2020 - `{MODIStsp}` 2.0.0 is out. Provides a new GUI interface based on Shiny, getting rid
+- 10/12/2020 - `{MODIStsp}` was resubmitted to CRAN after the maintainer's death.
+Now `{MODIStsp}` is dedicated to Lorenzo Busetto (https://docs.ropensci.org/MODIStsp/articles/lorenzo).
+
+- 01/09/2020 - `{MODIStsp}` 2.0.0 is out. Provides a new GUI interface based on Shiny, getting rid
 of the archived dependencies on gWidgets/gWidgetsRGtk2. Also provides much easier usage from 
 the CLI, by allowing to set all processing arguments also from the CLI. __Note:__ due to the 
 introduced changes, options files created with previous versions of `{MODIStsp}` will no 

README.md

@@ -57,7 +57,11 @@ For more information, documentation and examples of use, **see also the
 
 ## Important News
 
-  - 09/02/2020 - `{MODIStsp}` 2.0.0 is out. Provides a new GUI interface
+  - 10/12/2020 - `{MODIStsp}` was resubmitted to CRAN after the
+    maintainer’s death. Now `{MODIStsp}` is dedicated to Lorenzo Busetto
+    (<https://docs.ropensci.org/MODIStsp/articles/lorenzo>).
+
+  - 01/09/2020 - `{MODIStsp}` 2.0.0 is out. Provides a new GUI interface
     based on Shiny, getting rid of the archived dependencies on
     gWidgets/gWidgetsRGtk2. Also provides much easier usage from the
     CLI, by allowing to set all processing arguments also from the CLI.

cran-comments.md

@@ -42,16 +42,97 @@ In this submission I fixed a possible tentative of writing in the user library
 
 ```
 Possibly mis-spelled words in DESCRIPTION:
-  HDF (26:24)
-  MODIS (2:60, 22:10, 26:18, 27:60, 35:18)
-  Reflectance (28:50)
-  mosaicking (23:43)
-  rasters (21:63)
-  reflectance (29:67)
-  reprojection (23:55)
+  Busetto (40:5)
+  HDF (29:24)
+  MODIS (2:35, 25:10, 29:18, 30:60, 38:18)
+  Ranghetti (40:17)
+  mosaicking (26:43)
+  rasters (24:63)
+  reflectance (31:50, 32:65)
+  reprojecting (26:55)
+  resizing (26:72)
 ```
 All these words are correctly spelled.
 
+## CRAN resubmission review
+
+Please find below the answers to the CRAN reviewer.
+
+> Please reduce the length of the title to less than 65 characters.
+
+The title was changed from "A Tool for Automating Download and Preprocessing of 
+MODIS Land Products Data" to "Find, Download and Process MODIS Land Products".
+
+
+> Please only capitalize sentence beginnings and names in the description text.
+> e.g.  Quality Indicators --> quality indicators
+>          Spectral Indexes --> spectral indexes
+>          Surface Reflectance --> surface reflectance
+
+All capitalized letters were changed (unless sentence beginnings).
+
+
+> Please change:
+> products ,
+> -->
+> products,
+
+Done.
+
+
+> Please provide a link to the used webservices to the description field
+> of your DESCRIPTION file in the form
+> <http:...> or <https:...>
+> with angle brackets for auto-linking and no space after 'http:' and
+> 'https:'.
+
+No webservices were used (the MODIStsp Shiny GUI is launched from local PC).
+I added a reference to the paper which describes MODIStsp:
+Busetto and Ranghetti (2016) <doi:10.1016/j.cageo.2016.08.020>
+
+
+> You have examples for unexported functions.
+> Please either omit these examples or export these functions.
+> Used ::: in documentation:
+>       man/split_nodata_values.Rd:
+>          MODIStsp:::split_nodata_values(c("255", "250,254:255"))
+>       man/split_nodata_values.Rd:
+>          MODIStsp:::split_nodata_values(c("255", "250,254:255"),
+> take_all = FALSE)
+>       man/split_nodata_values.Rd:
+>          MODIStsp:::create_nodata_rcl(c("255", "250,254:255"), c("255",
+> "255"))
+
+Examples of unexported functions were removed.
+
+
+> Some code lines in examples are commented out in MODIStsp.Rd.
+> 
+> Please never do that. Ideally find toy examples that can be regularly
+> executed and checked. Lengthy examples (> 5 sec), can be wrapped in
+> \donttest.
+
+Examples were changed following these indications.
+All lenghy examples were wrapped in \donttest{}.
+\dontrun{} is no more used.
+
+
+> Please ensure that you do not use more than 2 cores in your examples,
+> vignettes, etc.
+
+Argument `parallel` was added to functions `MODIStsp()`, MODIStsp_process()`
+and `MODIStsp_process_bands()` (the only functions exploiting multicore 
+computation): if `parallel = FALSE`, single core is used.
+All examples and vignettes were edited setting `parallel = FALSE` everywhere.
+
+
+> Please always add all authors, contributors and copyright holders in the
+> Authors@R field with the appropriate roles.
+> e.g.: Babak Naimi
+
+Babak Naimi's contribution was added to the DESCRIPTION.
+
+
 MODIStsp 2.0.5
 ================